Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

!F Adding gifski gif converter #483

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pr8x
Copy link

@pr8x pr8x commented Jan 25, 2020

This is a working draft of integrating gifski into Captura. Things to consider:

  • I have not yet implemented GifskiOptions. The exe path is hardcoded at the moment.
  • In my experiments the produced files by gifski are actually quite a lot larger than the ones produced with the ffmpeg gif converter. We may want to play with the --quality and --fps option and/or downsample resolution (suboptimal). The USP of gifski is quality not compression, so we shouldn't expect too much.
  • In general I feel like parts of the code base could use some linting. Namespaces are quite inconsistent (Example: Some classes in the ffmpeg implementation use Captura.FFmpeg, most use Captura.Models). I think that should be fixed. Ideally, they should reside in a namespace named like the project/folder IMO.

Fixed issues: #457

@MathewSachin
Copy link
Owner

Looks good so far.
The namespace thing was what I wanted to do but put off due to other things. But, doing that for every folder might be an overkill. Namespaces as per the project name should be enough I think.

@pr8x
Copy link
Author

pr8x commented Feb 26, 2020

Hi I am currently quite busy with work so If anybody wants to actually fork this and add some option to download gifski in the settings... That would be cool!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants