WIP - #339 test fixing

MatrixAI · Mar 9, 2022 · 57f93b7 · 57f93b7
1 parent d3bf324
commit 57f93b7
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -29,7 +29,6 @@ lint:
   image: registry.gitlab.com/matrixai/engineering/maintenance/gitlab-runner
   stage: check
   interruptible: true
-  allow_failure: true
   script:
     - >
         nix-shell -I nixpkgs=./pkgs.nix --packages nodejs --run '

diff --git a/src/bin/vaults/CommandScan.ts b/src/bin/vaults/CommandScan.ts
@@ -4,7 +4,6 @@ import CommandPolykey from '../CommandPolykey';
 import * as binUtils from '../utils';
 import * as binOptions from '../utils/options';
 import * as binProcessors from '../utils/processors';
-import { LogLevel } from '@matrixai/logger';
 
 class CommandScan extends CommandPolykey {
   constructor(...args: ConstructorParameters<typeof CommandPolykey>) {
@@ -18,8 +17,7 @@ class CommandScan extends CommandPolykey {
     this.action(async (nodeId, options) => {
       const { default: PolykeyClient } = await import('../../PolykeyClient');
       const nodesPB = await import('../../proto/js/polykey/v1/nodes/nodes_pb');
-      this.logger.setLevel(LogLevel.INFO);
-      console.log(options);
+
       const clientOptions = await binProcessors.processClientOptions(
         options.nodePath,
         options.nodeId,
@@ -28,7 +26,6 @@ class CommandScan extends CommandPolykey {
         this.fs,
         this.logger.getChild(binProcessors.processClientOptions.name),
       );
-      console.log(clientOptions);
       const client = await PolykeyClient.createPolykeyClient({
         nodePath: options.nodePath,
         nodeId: clientOptions.nodeId,

diff --git a/src/client/service/vaultsScan.ts b/src/client/service/vaultsScan.ts
@@ -51,7 +51,6 @@ function vaultsScan({
       await genWritable.next(null);
       return;
     } catch (e) {
-      console.error(e);
       await genWritable.throw(e);
       return;
     }

diff --git a/tests/bin/vaults/vaults.test.ts b/tests/bin/vaults/vaults.test.ts
@@ -1,4 +1,4 @@
-import type { NodeAddress, NodeIdEncoded, NodeInfo } from '@/nodes/types';
+import type { NodeIdEncoded, NodeAddress, NodeInfo } from '@/nodes/types';
 import type { VaultId, VaultName } from '@/vaults/types';
 import os from 'os';
 import path from 'path';
@@ -33,7 +33,7 @@ jest.mock('@/keys/utils', () => ({
  */
 describe('CLI vaults', () => {
   const password = 'password';
-  const logger = new Logger('CLI Test', LogLevel.INFO, [new StreamHandler()]);
+  const logger = new Logger('CLI Test', LogLevel.WARN, [new StreamHandler()]);
   let dataDir: string;
   let passwordFile: string;
   let polykeyAgent: PolykeyAgent;
@@ -100,7 +100,6 @@ describe('CLI vaults', () => {
     });
   });
   beforeEach(async () => {
-    logger.setLevel(LogLevel.WARN);
     vaultName = genVaultName();
     command = [];
   });
@@ -693,10 +692,9 @@ describe('CLI vaults', () => {
     test.todo('test formatting of the output');
   });
   describe('commandScanNode', () => {
-    test.only(
+    test(
       'should return the vaults names and ids of the remote vault',
       async () => {
-        logger.setLevel(LogLevel.INFO);
         let remoteOnline: PolykeyAgent | undefined;
         try {
           remoteOnline = await PolykeyAgent.createPolykeyAgent({
@@ -729,7 +727,6 @@ describe('CLI vaults', () => {
             { PK_PASSWORD: 'password' },
             dataDir,
           );
-          console.log(result1);
           expect(result1.exitCode).toEqual(sysexits.NOPERM);
           expect(result1.stderr).toContain(
             'ErrorVaultsPermissionDenied: Permission was denied - Scanning is not allowed for',