Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce read buffer size for QUICStream #83

Closed
tegefaulkes opened this issue Jan 30, 2024 · 0 comments · Fixed by #84
Closed

Reduce read buffer size for QUICStream #83

tegefaulkes opened this issue Jan 30, 2024 · 0 comments · Fixed by #84
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices

Comments

@tegefaulkes
Copy link
Contributor

Specification

Right now each QUICStream has a single buffer used to read data out of quiche. The size of this is set using a constant value from quiche of about 1mb. As a result each QUICStream reserves 1MB of memory for it's lifespan. That is far too much memory to be used especially when we have multiple active connections going on.

The solution is to reduce this to a few KB at most. If it's not already it should be a configured value as well when creating a client or server.

Additional context

Related: #65 - Original approach to solving the problem but it was not appropriate.

Tasks

  1. Reduce the buffer used by each QUICStream for reading data out of quiche
  2. If it still needs to be done, this value needs to be set on construction of the QUICStream and by extension anything that creates a QUICStream.
@tegefaulkes tegefaulkes added the development Standard development label Jan 30, 2024
tegefaulkes added a commit that referenced this issue Jan 31, 2024
…readable buffer to 4kb

* Related: #83

[ci skip]
@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices
Development

Successfully merging a pull request may close this issue.

2 participants