Update to spec version of 1 April 2019 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when one branch calls pull(), it is possible that we call
read() - even though a read() is still pending from a previous pull()
call by the other branch. This can lead to reading too many chunks from
the original streams, and unnecessarily filling up the queues of the
branches past their high water mark.
This PR fixes that issue by only starting a new read() if the previous
read() was resolved. As a bonus, there will now be only one read() that
resolves with { done: true } when the original stream closes, so we no
longer need to keep track of whether we already closed the two branches.
MattiasBuelens
added
enhancement
domain: compliance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the implementation with spec version
6f94580of 1 April 2019.Comparison: whatwg/streams@2c8f35e...6f94580