Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite ReadableStream.pipeTo() using the public API #99

Merged
merged 20 commits into from
Oct 27, 2021
Merged

Rewrite ReadableStream.pipeTo() using the public API #99

merged 20 commits into from
Oct 27, 2021

Commits on Oct 26, 2021

  1. Implement pipeTo() using the public API (WIP)

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    bded0f3 View commit details
    Browse the repository at this point in the history

  2. Allow reader/writer.closed to settle before starting pipe loop

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    2158b08 View commit details
    Browse the repository at this point in the history

  3. Detect stream state from closed promise

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    e03f2c7 View commit details
    Browse the repository at this point in the history

  4. Combine closed promise reactions

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    89ce2d9 View commit details
    Browse the repository at this point in the history

  5. Don't start pipe loop if already shutting down

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    9fd38ba View commit details
    Browse the repository at this point in the history

  6. Reimplement WritableStreamDefaultWriterCloseWithErrorPropagation

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    88e71a0 View commit details
    Browse the repository at this point in the history

  7. Ignore errors from closed promises after releasing reader/writer

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    f03d40a View commit details
    Browse the repository at this point in the history

  8. Wait for initial source/dest state before running shutdown actions

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    5250596 View commit details
    Browse the repository at this point in the history

  9. Remove early return when signal is already aborted

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    4e9ab0f View commit details
    Browse the repository at this point in the history

  10. Skip broken test

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    392eb5e View commit details
    Browse the repository at this point in the history

  11. Wait for both reads and writes to finish before finalizing pipe

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    d77b1dd View commit details
    Browse the repository at this point in the history

  12. Ignore a few more tests for now

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    f20ac4a View commit details
    Browse the repository at this point in the history

  13. Fix indentation

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    c48e1b1 View commit details
    Browse the repository at this point in the history

  14. Simplify

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    6739f40 View commit details
    Browse the repository at this point in the history

  15. Re-implement close with error propagation

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    8b06dbf View commit details
    Browse the repository at this point in the history

  16. Add extra delay to allow reader.closed and writer.closed to settle

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    f2b9d19 View commit details
    Browse the repository at this point in the history

  17. Re-enable test

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    5eaafbf View commit details
    Browse the repository at this point in the history

  18. Add extra unit test for skipped pipe WPT test

    @MattiasBuelens
    MattiasBuelens committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    74d782f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Add extra tests for skipped multiple propagation WPT tests

    @MattiasBuelens
    MattiasBuelens committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    a93fc55 View commit details
    Browse the repository at this point in the history

  2. Document new WPT failures

    @MattiasBuelens
    MattiasBuelens committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    4903491 View commit details
    Browse the repository at this point in the history