Introduce mbedtls_ssl_hs_cb_t typedef #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gstrauss
force-pushed
the
inline-cert_cb
branch
from
eb0a4f2
to
c5c2d8d
Compare
gstrauss
force-pushed
the
inline-cert_cb
branch
from
c5c2d8d
to
7cb383f
Compare
minosgalanakis
added
needs-review
gstrauss
force-pushed
the
inline-cert_cb
branch
from
7cb383f
to
d865edf
Compare
ChangeLog.d/mbedtls_ssl_hs_cb_t.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| Features | |||
| * Introduce mbedtls_ssl_hs_cb_t typedef. | |||
There was a problem hiding this comment.
It would be useful for the reader, I think, to know what this typedef is used for as well as what it is called.
ChangeLog.d/mbedtls_ssl_hs_cb_t.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| Features | |||
| * Introduce mbedtls_ssl_hs_cb_t typedef. | |||
| * Inline func for mbedtls_ssl_conf_cert_cb(). | |||
There was a problem hiding this comment.
I don't think this is major enough to warrant an entry in the changelog.
gstrauss
force-pushed
the
inline-cert_cb
branch
from
d865edf
to
227930f
Compare
AndrzejKurek
removed
the
needs-reviewer
Inline func for mbedtls_ssl_conf_cert_cb() Signed-off-by: Glenn Strauss <[email protected]>
|
ABI-API is expected, pr-merge failing is OpenCI Failure. |
paul-elliott-arm
removed
the
needs-review
paul-elliott-arm
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR from discussion with @mpg in #5454.
#5454 (comment)
#5454 (comment)
This PR aims to slightly improve the interface. This PR is lower priority as this is not a fix to anything.
Related question: should all new interfaces which are simple getter/setter functions be inlined in the header when struct definition is visible, even if the inline func uses MBEDTLS_PRIVATE? (e.g. setter/getter for
mbedtls_ssl_configandmbedtls_ssl_contextare available, butstruct mbedtls_ssl_handshake_params(library/ssl_misc.h) is not visible.) Note: This should not be done for older interfaces (until possibly after a major version bump) since compiled application code might hold references to the symbols.Status
READY
Requires Backporting
NO
Migrations
NO
Todos