small formal changes from NCBI (January 2023) #6930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some identifiers (e.g. mbedtls_free) can name either functions or macros depending on configuration settings. For those that turn out to name macros, first clear out any existing macro definitions to accommodate possible unconditional bulk symbol renaming. Signed-off-by: Aaron M. Ucko <[email protected]>
At least in the context of ecp_double_jac, the output pointer may equal the first input pointer, in which case copying is not only superfluous but results in "Source and destination overlap in memcpy" errors from Valgrind. Signed-off-by: Aaron M. Ucko <[email protected]>
|
Hi, Given the two commits are on quite different subjects, I am going to suggest it might be a good idea to split these two. It would certainly make review easier. |
|
That's fair; I wasn't sure which would be the lesser evil given that each PR has some baseline overhead. I'm off today, but can per-commit PRs later in the week, quite possibly tomorrow.
|
|
The bignum change is desirable. It needs a changelog entry referencing #6701. The platform.h change has me puzzled. If it's making the build pass, isn't it hiding a genuine error? |
|
I'll add a changelog entry; thanks for pointing out the relevant issue.
The platform.h change is in the context of an unsubmitted local change that adds a header renaming any symbol that winds up with a global definition on Windows, Linux, macOS, or FreeBSD with our (relatively mainstream) configuration and includes it from mbedtls_config.h (or config.h in our case, since we're using the LTS branch). Because these renames are unconditional for simplicity and to err on the side of overshooting, they can clash with macros from platform.h. Sorry for not explaining it more clearly earlier.
|
This was referenced Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have been using lightly patched Mbed TLS LTS sources and headers in a product and would like to get my changes upstream, both so I can stop carrying patches and because they may be of broader interest. I will propose backports to the LTS branch in due course, but am starting with the development branch per SOP. My changes are mutually independent, but small; please let me know if I should formally split them into individual PRs. Also, I'm not sure either merits mention in the ChangeLog, but will be happy to propose text if you feel otherwise.
FWIW, my original patch to
platform.hfocused exclusively on(v)snprintf, but I figured I might as well generalize it.Thanks in advance for considering these changes, and please let me know if you have any questions or concerns.
Gatekeeper checklist
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.