Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isAdmin and isGlobalModerator fields to user api response #1044

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Add isAdmin and isGlobalModerator fields to user api response #1044

merged 3 commits into from
Aug 20, 2024

Conversation

BentiGorlich
Copy link
Member

Link #1001

@BentiGorlich BentiGorlich added enhancement New feature or request backend Backend related issues and pull requests api API related issues and pull requests labels Aug 19, 2024
@BentiGorlich BentiGorlich requested a review from jwr1 August 19, 2024 17:50
@BentiGorlich BentiGorlich self-assigned this Aug 19, 2024
@jwr1
Copy link
Member

jwr1 commented Aug 19, 2024 •
edited
Loading

Would you be able to add this to the user small fields as well? The way you have it, if an admin or global mod made a post about something, you would not be able to tell they are the admin until actually viewing their profile page (/api/users/*).

@jwr1
Copy link
Member

jwr1 commented Aug 19, 2024

Like this:
image

@BentiGorlich
Copy link
Member Author

Done

melroy89
melroy89 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jwr1
jwr1 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@jwr1 jwr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it, looks good to me!

@BentiGorlich BentiGorlich merged commit 4973e4a into main Aug 20, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the new/api-add-user-admin-moderator-fields branch August 20, 2024 13:50
@jwr1 jwr1 mentioned this pull request Aug 20, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwr1 jwr1 jwr1 approved these changes

@melroy89 melroy89 melroy89 approved these changes

Assignees

@BentiGorlich BentiGorlich

Labels
api API related issues and pull requests backend Backend related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BentiGorlich @jwr1 @melroy89