Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push navbar front route generation into twig func #1058

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

asdfzdfj
Copy link
Contributor

pushed the block of conditions that's used in templating head navbar link to threads/microblogs page from twig templates to existing navbar_*_url function

makes the template a bit easier to work with and consolidate new path selection/generation logic into one place

@melroy89 melroy89 added the backend Backend related issues and pull requests label Aug 24, 2024
@asdfzdfj asdfzdfj added frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end and removed backend Backend related issues and pull requests labels Aug 24, 2024
pushed the block of conditions that's used in templating head navbar
link to threads/microblogs page from twig templates to existing
`navbar_*_url` function

makes the template a bit easier to work with and consolidate new path
selection/generation logic into one place
@asdfzdfj asdfzdfj force-pushed the fix/consolidate-front-route-linking branch from d5f2015 to 6aa2194 Compare August 24, 2024 12:51
@asdfzdfj asdfzdfj merged commit bee8659 into main Aug 24, 2024
7 checks passed
@asdfzdfj asdfzdfj deleted the fix/consolidate-front-route-linking branch August 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants