Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
openssl_sign
fails the$signature
will be null. Resulting into errors like this:We can better check on the return value of
openssl_sign
to validate if the signature actually succeeded or not.If not, we now log a better error message. And we leave out the
Signature
header for now. We could also throw an error and abort. Ideas are welcome here.Also we now free the memory of the
$key
using the appropriateopenssl_free_key
method.