preview controller memoize response #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentiGorlich
added
enhancement
BentiGorlich
approved these changes
Aug 4, 2024
adjusted preview controller to clear its content on close, but at the same time also memoize the embed response from the server the should help in dealing with e.g. youtube embed preview where simply hiding the preview container would not make it stop, and there's no good way to universally stop embed media players other than to erase them out entirely, while not making extra requests to the server when the preview is being repeatedly shown/hidden in the same page session
asdfzdfj
force-pushed
the
new/preview-memoize-response
branch
from
ffade4d
to
dbabe43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjusted preview controller to clear its content on close, but at the same time also memoize the embed response from the server
the should help in dealing with e.g. youtube embed preview where simply hiding the preview container would not make it stop, and there's no good way to universally stop embed media players other than to erase them out entirely, while not making extra requests to the server when the preview is being repeatedly shown/hidden in the same page session