Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to rename a function in the clone view #30

Open
wants to merge 2 commits into
base: master2.x
Choose a base branch
from

Conversation

mrexodia
Copy link

@mrexodia mrexodia commented May 2, 2019

I don't expect this to get merged as-is, but I am not familiar with the codebase or how to set up a dev environment so this is the best I could do in a short time.

Improvements needed:

  • Properly escape the function name since there are two points of potential arbitrary code execution with a well-crafted name now;
  • Use some fancy web yes/no box instead of window.question;
  • Use an icon (optional, because for me tooltips are not working).

With regards to the workflow, I'd like to search for a function and if I think it's a good match manually rename it from the web ui.

@steven-hh-ding
Copy link
Contributor

Hi! Thank you for the contribution! Actually we didn't have any setup for developing the plugin yet, I just edited like you did. For the backend codebase we use Eclipse or VScode with Maven. Let me know if you need anything; I can help with you for this feature.

We are also thinking a way to download and transfer the IDA comments from the backend to the IDB file, or even the renamed variables etc. Let me know if this also fits well to your workflow.

Best,

Steven

@steven-hh-ding steven-hh-ding self-assigned this May 4, 2019
@mrexodia
Copy link
Author

mrexodia commented May 4, 2019

Maybe it will help to illustrate my use case better...

In my case I have binaries with symbols that I index. I also have a binary that I’m analyzing, without symbols and I would like to semi-manually search functions and rename them. The only thing I really need are the function names because I don’t have any other information. Mostly I’m using the decompiler, so normal comments are only moderately useful. Syncing the function signature would be useful, but IDA doesn’t support the name mangling so I think renaming should be enough for normal cases.

One thing I’ll probably do next is automatically expand the resulting tree if there are only a few entries, but overall I think your tool is amazing and it already did the bulk of the jtfor me, so thanks a lot!

With regards to development, the main thing I’d like is to have the static web directory loaded from the hdd instead of the jar, because now I have to restart the server every time I want to make a change, maybe you could assist me with that? I don’t know anything about java so I’d like to avoid actually compiling the whole thing...

@steven-hh-ding
Copy link
Contributor

Sorry for the late followup. I was traveling. We will add auto expand for the tree for sure. I will try separating the html file from the Jar. But there is chance that one still cannot edit it when separated. If you import the whole maven project to Eclipse and run it through there, then the server does not need to restart every time. The main class is in the kam1n0-app project. We are also thinking to add a batch search, quick review, and meta-data (name) transfer. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants