Add data descriptor header #40
Conversation
Fix archive for 7zip
|
Seems the tests are not happy. Must be the extra 4 bytes. |
|
@rullzer tests are broken on master as well - this repo seems dead-ish I fixed the tests and some other bugs in my own fork - https://github.com/DeepDiver1975/PHPZipStreamer Feel welcome to contribute there. Cheers! |
|
@DeepDiver1975 good to know will do that then :) |
rullzer
force-pushed
the
data_descriptor_header
branch
2 times, most recently
from
b061997
to
bc2fd5d
Compare
As specified in 4.3.9.3 and 4.3.9.4
4.3.9.3 Although not originally assigned a signature, the value
0x08074b50 has commonly been adopted as a signature value
for the data descriptor record. Implementers should be
aware that ZIP files may be encountered with or without this
signature marking data descriptors and SHOULD account for
either case when reading ZIP files to ensure compatibility.
4.3.9.4 When writing ZIP files, implementors SHOULD include the
signature value marking the data descriptor record. When
the signature is used, the fields currently defined for
the data descriptor record will immediately follow the
signature.
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
data_descriptor_header
branch
from
bc2fd5d
to
a910389
Compare
Signed-off-by: Roeland Jago Douma <[email protected]>
|
@DeepDiver1975 don't understand what to do with your own fork. Could you please explain it to me |
Getting the latest release of owncloud will give you the necessary changes to this library. Just upgrade and you'll be happy. |
|
@DeepDiver1975 i already made a test (with a newinstallation of owncloud-10.0.8 |
please head over to https://central.owncloud.org/ to seek for help. Maybe there is one corner case missing? We will have a look. |
|
sorry don't know what to do there. |
I can only speak for owncloud and yes - this issue should be solved with 10.0.8. |
As specified in 4.3.9.3 and 4.3.9.4
4.3.9.3 Although not originally assigned a signature, the value
0x08074b50 has commonly been adopted as a signature value
for the data descriptor record. Implementers should be
aware that ZIP files may be encountered with or without this
signature marking data descriptors and SHOULD account for
either case when reading ZIP files to ensure compatibility.
4.3.9.4 When writing ZIP files, implementors SHOULD include the
signature value marking the data descriptor record. When
the signature is used, the fields currently defined for
the data descriptor record will immediately follow the
signature.
This (in zip32) makes the generated files work on the default OSX app.