Add generated bindings for Qt 5.15 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbean-bremen
approved these changes
Jan 31, 2024
|
Please tag an release candidate 2 on this master branch commit. |
|
Done. |
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated bindings for Qt 5.15.
It is somewhat hard to compare the generated code with the previous version, since we changed some general things (override instead of virtual), and because new classes push later classes to different header files. At a cursory inspection everything seems ok, though some generated methods may have been dropped (e.g. because they are inherited from a base class). Ah yes, and QRegularExpression is now a builtin type instead of QRegExp.
If you notice something is missing relative to Qt 5.11, please notify me.