-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving LLVM tests #10
Improving LLVM tests #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments added. At least one change needs further inputs from @cme
llvm/test/tools/UpdateTestChecks/update_llc_test_checks/mips_generated_funcs.test
Outdated
Show resolved
Hide resolved
- Fix instructions conflicts between NanoMips and other Mips targets that caused tests from the MC/Mips group to fail - Fix several tests - Fix debug location of SP adjustment instruction that caused DebugInfo/Mips/delay-slot.ll test to fail - Add 'nanomips' feature to llvm-lit config script so that tests can be marked as UNSUPPORTED for NanoMips target
f74fe37
to
b2e79de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more changes required.
I suggest you add more commits instead of force-pushing on the pull request. I'll squash-and-merge all the changes once approved to get a clean history.
- Fix expected output for jumptable.ll and mips_generated_funcs.ll tests
- No longer need to mark a test ExtDebugInfo.cpp that needs object emitter as UNSUPPORTED - Delete line left behind by a merge conflict in sanitize-coverage-old-pm.c test
Added one more commit which fixes last two of failing clang tests. Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These changes fix the remaining 13 failing LLVM tests when running
ninja check-llvm
: