-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed 'format()' function from the README as this function doesn't exists #492
Open
sheepbild
wants to merge
250
commits into
analysis-lKoEdw
Choose a base branch
from
master
base: analysis-lKoEdw
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Eloquent Refactoring * enhancement * Update src/Http/Livewire/LivewireDatatable.php Co-authored-by: Wouter van Marrum <[email protected]> * Using Conditional Clauses instead of Conditional Statement Co-authored-by: Wouter van Marrum <[email protected]>
Co-authored-by: Mark Salmon <[email protected]>
* Eloquent Refactoring * Eloquent Refactoring * Eloquent Refactoring * Remove Spaces
* Update LivewireDatatable.php In getSortString() the default is to use a back tick " ` " for the order by field. This causes an error in postgresql which likes it to be ' " '. My fix is to test the enviroment variable, and if it is set to "pgsql" it will use ' " ' otherwise it will give " ` ". * Update LivewireDatatable.php Changed quotation style.
* fix mobile paginator links * fix combined truncate and search * Add configuration option that suppresses highlighting. * add highlighting method more usable to user space inside callback, namely 'highlightStringWithCurrentSearchTerm' * Make possible to disable highlighting Co-authored-by: Mark Salmon <[email protected]> Co-authored-by: jjrohrer <[email protected]>
Co-authored-by: Mark Salmon <[email protected]>
* fix mobile paginator links * fix combined truncate and search Co-authored-by: Mark Salmon <[email protected]>
* Update README.md Fix spelling * Update README.md
* wip * remove dd
Did not search properly when using Uppercase in search key.
* ignores * cleanup * php8 support
Raw html output that can cause simple takeover by displaying user-entered data should be the hard path (another modifier), not the easy one. Example: Display results from a table containing <script>alert('woof!');</script>
* Fix a bug with Multiple filter on boolean column * fix indent Co-authored-by: Nicolas Plassart <[email protected]>
If we specify a custom agreggate (max, avg, min, ...) use this aggregate for filtering data Also fix filtering when null values are returned with aggregates
I went source diving and found this option can be used in the config, so I think it would be easier for users to see the default in the config so they know they can easily change it.
improve the way to-be-exported columns are discovered
Fix typos in README.md
Bugfix toggleSelectAll() with groupBy() in query builder
The backtick on the sort string for sqlserv breaks query.
Column: introduce ability to pass custom data when using view()
… Date/DateTime types. (#450) * Add support to set start and end date filter default. This is required to be changed to work with smalldatetime in MS SQL Server. * Added proper support for database type detection for sort order. Co-authored-by: Mark Salmon <[email protected]> Co-authored-by: Herbert Maschke <[email protected]> Co-authored-by: Shane Burrell <[email protected]>
Add fix to possible error when install on laravel 9 composer require psr/simple-cache:^1.0 maatwebsite/excel
* Added column to 'fieldEdited' event * Added column check to 'fieldEdited' event * Change alpine key to wire key
…th values containing eg. "-" (#486)
- Set variable $useThrough AFTER checking if relation is an instance of HasMany, HasManyThrough or BelongsToMany. Otherwise, it will return an error because no joins property exists for $this->query->getQuery()
Add table prefix to the table variable in the customWithAggregate and hasAggregate EloquentBuilder macros registerd by the service provider.
Added defaultFilters to Livewire Datatables
Bugfix checkboxes behavior when search or filters are active - If the search or filter is active, we must display the count of checked rows only for "visible" items (results of search or filtered results). Therefore, the toggleSelectAll() method must also check or uncheck all "visible" items when the search or filters are active.
check which database driver is used and build the query according to its dialect. added SQLite dialect only, partially fiexs issue #183
Fix to prevent addGlobalSearch method to prepend tablePrefix when column contains '_concat_'. It was generating a syntax error in the query, i.e.: SQLSTATE[42000]: Syntax error or access violation: 1305 FUNCTION **DBNAME**.**TABLEPREFIX**CONCAT_WS does not exist
It would be useful to be able to control the toggleGroup method from foreign livewire components
* Create DatetimeColumn.php * Create datetime.blade.php * Added DatetimeFilters to LivewireDatatable * Changed doDateFilterStart and doDateFilterEnd to doDatetimeFilterStart and doDatetimeFilterEnd on filter * Fix the issue detected by ci, and created a new config named "default_datetime_format"
* Bump dependencies for Laravel 10 * Update composer.json --------- Co-authored-by: Shift <[email protected]>
Added L10 version for reedware/laravel-relation-joins package
* Update LivewireDatatables to support DB::raw with laravel version 10. * Update style * Switch to correct function. * Switch to correct function. * Fix style. * Update x-datatables.x-circle to x-icon * Update x-datatables.x-circle to x-icon
Co-authored-by: Juan Moscoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following to this issue :
#490 (comment)
This is my first pull request on GitHub, a simple correction in the README but this is a beginning ! :)
IDK what are the "analysis" branchs, so i took the last, if someone can explain to me what it means