Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi table pagination #497

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

elegasoft
Copy link

Resolves #496: Allow for independent query string pagination with multiple datatables on the same page

Function:

By using the WithMultiTablePaginator one can rely on the query string parameters to separately paginate multiple LivewireDatatable's which are rendered on the same page.

Requirements:

Requires that the DataTableComponent use WithMultiTablePaginator; and declare either a $pageName or $name property on the DataTableComponent.

class WorkInProgressDataTable extends LivewireDatatable
{

    use WithMultiTablePaginator;

    /// Requires declaration of $name
    public $name = 'wip';

    /// or declaration of 
    public $pageName = 'wipPage';
   ...
}

How it works:

  1. The WithMultiTablePaginator overrides all pagination related calls to ensure that it applies the $pageName or LivewireDatatable $name properties.
  2. It also ensures that calls to the getResultsProperty() also paginates based on the page related to $pageName or LivewireDatatable $name property.

Tests:

-- Work In Progress --

Discussion Points:

  1. Naming seems to be a bit off, maybe rename the trait to WithCustomPaginator?
  2. There are no other Exceptions thrown by this plugin, instead of throwing an exception we can provide a default $pageName using static::class?

@thyseus
Copy link
Collaborator

thyseus commented Aug 10, 2022

I like the idea with using Traits a lot, but shouldnt it be possible to use multiple tables on the same page by default without using a Trait ?

@mrtorks
Copy link

mrtorks commented Feb 21, 2023

Hi all. Any update in this feature. It would really be awesome to have this implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for independent query string pagination with multiple datatables on the same page
3 participants