Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10.x Compatibility #537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^9.5.10. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/livewire-datatables.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "mediconesystems/livewire-datatables": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@RalpinMcDjango
Copy link

Can we please get this merged if this is all thats required to update to laravel 10?

@johnnuman
Copy link
Contributor

johnnuman commented Mar 23, 2023

@laravel-shift the composer.json still needs to be updated to include dev-l10-compatibility for reedware/laravel-relation-joins package. It does not update as is.

I have created a PR for your branch too.

Anyone bumping into it for now, can use my fork for Laravel v10 installation until this is all sorted out.

@PacoHolliday
Copy link

@johnnuman

Anyone bumping into it for now, can use my fork for Laravel v10 installation until this is all sorted out.

Still can't install normally via Composer...
How can I use your fork? I got " fatal: repository 'https://github.com/johnnuman/livewire-datatables/tree/l10-compatibility.git/' not found" when I tried to clone it.
Thanks!

@schmeits
Copy link
Contributor

https://github.com/tylernathanreed/laravel-relation-joins v4.x is L10 compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants