This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Dependencies: change tilde to caret #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A critical security fix has just been released for max-mapper/extract-zip@v1.6.5...v1.6.6 If you accept this PR, then people installing phantomJS will automatically get the fix as a dependency. 🙏 Please do this so that the people still actually using this project aren't bitten for it. |
|
I just pushed a commit to make sure All we would need after merging is a publish to npm 🙏 |
Most immediately, this will fix #745 and will obviate the need for constant fixes like #742 #679 #732 #698 #653 Particularly, this will be helpful from a maintenance perspective, as these dependencies will likely have multiple security patches in the future. This change will also allow `npm` / `yarn` to better dedupe dependencies.
|
should be published now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most immediately, this will fix #745
and will obviate the need for constant fixes like
#742
#679
#732
#698
#653
Particularly, this will be helpful from a maintenance perspective, as these dependencies will likely have multiple security patches in the future.
This change will also allow
npm/yarnto better dedupe dependencies.