Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dumper equipment update #4613

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Dumper equipment update #4613

merged 3 commits into from
Jul 10, 2023

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Jul 9, 2023 •
edited
Loading

This PR

  • adds a postLoadInit for Dumper equipment that tries linking dumpers to cargo in the same location
  • changes the weight calculation for dumpers to consider linked cargo (instead of cargo bays which I think can't be used on industrial meks)
  • changes two affected units to include cargo for their dumpers; the other units with dumpers all now seemed to calculate their weight perfectly
    Fixes Dumper doesn't calculate mass properly megameklab#488

@NickAragua NickAragua merged commit 0b3de86 into MegaMek:master Jul 10, 2023
4 checks passed
@SJuliez SJuliez deleted the dumper branch July 24, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickAragua NickAragua NickAragua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dumper doesn't calculate mass properly
2 participants
@SJuliez @NickAragua