CodeUtilities: Add Unit Testing #4624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windchild292
added
Bug
Tests
SJuliez
approved these changes
Jul 14, 2023
|
Objects.compare doesn't handle one parameter being null and the other being not null... just both having values or both being null. |
NickAragua
reviewed
Jul 14, 2023
| // The order of operations is important here, to not lose precision | ||
| return min * (1L - f) + max * f; | ||
| return Math.round(min * (1L - f) + max * f); |
There was a problem hiding this comment.
Every time I see a change to a "deep library" function like this, I get scared. Do we have any idea where it's used? And if so, can we get a short write-up of stuff that can be tested from the user side to see if the change "affects" anything?
There was a problem hiding this comment.
According to my IDE the lerps are not currently used at all. I guess it's safe to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1 adds unit tests, commit 2 expands Javadocs and fixes a rounding bug in MathUtility's long lerp.