Feature - Add audio tab and master volume setting #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammerGS
added
the
For New Dev Cycle
|
Thanks for the PR. We are getting close to the 0.49.14 Dev release, so this will get tagged with a "For new dev cycle (49.15). If you haven't joined our Discord I'd recommend joining it as its an easy way to get feedback. |
NickAragua
approved these changes
Jul 23, 2023
sensualcoder
force-pushed
the
add-audio-tab
branch
from
0674a0e
to
b563520
Compare
Wire up new classes to use the master volume setting to change the volume of sound output
Add AudioService interface for other possible users, and SoundType enum for current sounds
sensualcoder
force-pushed
the
add-audio-tab
branch
from
b563520
to
a6ceeb8
Compare
|
Updated this PR with some small changes |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
NickAragua
requested changes
Aug 7, 2023
|
Added some comments explaining the Sound class and methods and the methods in SoundManager. Let me know if I should add more :) |
kuronekochomusuke
removed
the
For New Dev Cycle
NickAragua
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Master Volume setting to the application to control the sound output, and also moves the audio settings into a new tab in the Client Settings menu.
In addition, there is a new Sound class that encapsulated storing and playing sound files, and a SoundManager class to provide an interface for all of the current sounds effects as well as handling audio settings changes.