Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow free facing change only after aerospace maneuvers that allow it. #4663

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

neoancient
Copy link
Member

Currently facing changes are allowed after any aerospace maneuver, but these should only apply to the immelmann, the hammerhead, and the split-s.

Fixes #4606.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@gsparks3
Copy link
Collaborator

One question while we're looking at this - does the current code allow choosing any facing after a hammerhead maneuver? Should only be a 180° flip. Not familiar enough with the code to tell just by looking.

Other two maneuvers can indeed select any facing afterwards.

@neoancient
Copy link
Member Author

That's what I get for relying on my faulty memory. Or maybe I thought the hammerhead could end facing any direction because MM allows it.

@neoancient neoancient merged commit dde5a05 into master Jul 27, 2023
4 checks passed
@neoancient neoancient deleted the maneuver_facing_change branch July 27, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[49.13] Half-roll maneuver allows illegal facing change for aerospace fighter
3 participants