Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit tooltip display tank crits in mini armor display #4678

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Jul 29, 2023

  • unit tooltip - display tank crits in mini armor display
  • show Stabilizers, Turret Locked, Engine, Sensors, Motive System Damage Level

image
image
image
image

fixes #4636

@kuronekochomusuke kuronekochomusuke marked this pull request as draft July 29, 2023 18:45
@kuronekochomusuke kuronekochomusuke added the In Development (Draft) An additional way to mark something as a draft. Make it stand out more. label Jul 29, 2023
@JonhyBurner
Copy link

It might be a matter of opinion, but when moderate and hevy motive damage occurs, maybe lower levels should be crossed out as well, to be more visually consistent.

@gsparks3
Copy link
Collaborator

gsparks3 commented Jul 29, 2023

No, those crits happen separately, and need to be noted separately (it's basically noting which of them are currently being applied to Driving Skill Rolls; you can actually get multiple instances of each, but the DSR penalties do not stack from multiple crits of the same type, only from crits of different types - although the MP penalties from duplicate motive crits do stack).

@SJuliez
Copy link
Member

SJuliez commented Jul 29, 2023

I suggest not displaying anything until damage has occurred.

@kuronekochomusuke
Copy link
Collaborator Author

for me I prefer to see the undamaged ones, so you can see which hits the unit can take.

@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review August 6, 2023 23:23
@kuronekochomusuke kuronekochomusuke removed the In Development (Draft) An additional way to mark something as a draft. Make it stand out more. label Aug 6, 2023
Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just puzzled about one thing.

megamek/src/megamek/common/Entity.java Show resolved Hide resolved
@NickAragua NickAragua merged commit 446bd9c into MegaMek:master Aug 8, 2023
4 checks passed
@kuronekochomusuke kuronekochomusuke deleted the unitToolTipTankCrits branch October 25, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Show motive crits on unit display and/or tooltip for vehicles
5 participants