Avoid penalizing Improved Heavy Lasers in weapon bays #5918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saklad5
force-pushed
the
heavy-laser-fix
branch
from
73dbc79
to
364759a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5918 +/- ##
============================================
- Coverage 28.90% 28.90% -0.01%
+ Complexity 13929 13926 -3
============================================
Files 2539 2539
Lines 268363 268361 -2
Branches 47933 47930 -3
============================================
- Hits 77579 77576 -3
+ Misses 186819 186817 -2
- Partials 3965 3968 +3 ☔ View full report in Codecov by Sentry. |
Saklad5
force-pushed
the
heavy-laser-fix
branch
from
364759a
to
4f537c7
Compare
While heavy lasers incur an accuracy penalty, this obviously isn't meant to apply to improved heavy lasers, which are improved specifically by avoiding that. The check has also been made a bit more efficient.
Saklad5
force-pushed
the
heavy-laser-fix
branch
from
4f537c7
to
f21c91c
Compare
IllianiCBT
added
the
For New Dev Cycle
NickAragua
reviewed
Sep 4, 2024
| weapon.getBayWeapons().stream() | ||
| .map(WeaponMounted::getType) | ||
| .map(WeaponType::getInternalName) | ||
| .anyMatch(i -> i.startsWith("CLHeavyLaser"))) { |
There was a problem hiding this comment.
Is "CLHeavyLaser" the "Improved Heavy Laser"?
There was a problem hiding this comment.
No, it’s the unimproved versions. If that matches, it applies the penalty.
SJuliez
removed
the
For New Dev Cycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing bug with Improved Heavy Lasers getting an accuracy penalty in weapon bays.
It also makes the check quite a bit more efficient, replacing two O(n) calls with one O(1) call. I might skim through the code later and see if I can make similar changes elsewhere.