Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data update - line wrapping and consolidating availability ratings #6082

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

SuperStucco
Copy link
Collaborator

Fixes the line wrapping that propagated from the mass naming/line length/general formatting fix. Great for code, less so for data.

Also consolidates a number of redundant availability values to remove redundant data - lower chance of editing errors later, easier to automatically transcribe contents if at some point this is moved to YAML or other format.

As an example, an availability list of

... ,CC:6, ... ,IS:6,FS:6, ... ,LA:6,FWL:6, ...

is simplified down to ... ,IS:6, ... as the major IS factions are already covered under the IS parent faction with the same availability value.

Similarly, major Periphery factions have been consolidated down under the parent Periphery faction and most of the Clan factions have been consolidated under the CLAN faction.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.11%. Comparing base (0cace95) to head (ff4ae0a).
Report is 181 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6082      +/-   ##
============================================
+ Coverage     29.07%   29.11%   +0.04%     
- Complexity    13958    13979      +21     
============================================
  Files          2576     2601      +25     
  Lines        267398   267090     -308     
  Branches      47803    47749      -54     
============================================
+ Hits          77744    77771      +27     
+ Misses       185755   185412     -343     
- Partials       3899     3907       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT
Copy link
Collaborator

Bless you for doing this

@IllianiCBT IllianiCBT merged commit 0f57000 into MegaMek:master Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants