Read Mekset as UTF8 #6087
Merged
Read Mekset as UTF8 #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6087 +/- ##
============================================
- Coverage 29.11% 29.11% -0.01%
+ Complexity 13979 13978 -1
============================================
Files 2601 2601
Lines 267090 267090
Branches 47749 47749
============================================
- Hits 77771 77769 -2
- Misses 185412 185415 +3
+ Partials 3907 3906 -1 ☔ View full report in Codecov by Sentry. |
|
CodeQL is about logging stuff that had been logged before. Not relevant for this fix. |
HammerGS
approved these changes
Oct 11, 2024
|
@SJuliez Am I right to think the CodeQL errors are false-positives? |
|
I realized I could have got my answer by just reading one message up >_> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unit icon lookup for units with diacritics in the name such as Götterdämmerung and Gùn by reading the mekset file as UTF8. This error only appeared in releases, not in the IDE. Also adds the Locale.ROOT to the uppercase calls to make it (supposedly) less dependent on locale.
Also fixes small errors in the mekset itself.