#6013: Mine Clearance Missile fixes #6118
Merged
+107
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6118 +/- ##
=========================================
Coverage 29.07% 29.08%
Complexity 13972 13972
=========================================
Files 2601 2601
Lines 267447 267415 -32
Branches 47758 47740 -18
=========================================
Hits 77767 77767
+ Misses 185782 185750 -32
Partials 3898 3898 ☔ View full report in Codecov by Sentry. |
kuronekochomusuke
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6013
MC missiles now count as being able to clear mines. Also, MML MC missiles now use the correct handler to actually clear mines.