Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #41

Merged
merged 6 commits into from
Apr 10, 2020
Merged

Various improvements #41

merged 6 commits into from
Apr 10, 2020

Conversation

roblabla
Copy link
Member

@roblabla roblabla commented Apr 7, 2020

No description provided.

@todo
Copy link

todo bot commented Apr 7, 2020

DSO Module Offset (unused)

linkle/src/format/nxo.rs

Lines 280 to 290 in 4d984ea

// TODO: DSO Module Offset (unused)
output_writter.write_u32::<LittleEndian>(0)?;
// Reserved (unused)
output_writter.write_u32::<LittleEndian>(0)?;
// TODO: apiInfo
output_writter.write_u64::<LittleEndian>(0)?;
// .dynstr section info
output_writter.write_u32::<LittleEndian>(self.dynstr_section.as_ref().map(|v| u32::try_from(v.addr).unwrap()).unwrap_or(0))?;
output_writter.write_u32::<LittleEndian>(self.dynstr_section.as_ref().map(|v| u32::try_from(v.size).unwrap()).unwrap_or(0))?;


This comment was generated by todo based on a TODO comment in 4d984ea in #41. cc @MegatonHammer.

@todo
Copy link

todo bot commented Apr 7, 2020

apiInfo

linkle/src/format/nxo.rs

Lines 285 to 295 in 4d984ea

// TODO: apiInfo
output_writter.write_u64::<LittleEndian>(0)?;
// .dynstr section info
output_writter.write_u32::<LittleEndian>(self.dynstr_section.as_ref().map(|v| u32::try_from(v.addr).unwrap()).unwrap_or(0))?;
output_writter.write_u32::<LittleEndian>(self.dynstr_section.as_ref().map(|v| u32::try_from(v.size).unwrap()).unwrap_or(0))?;
// .dynsym section info
output_writter.write_u32::<LittleEndian>(self.dynsym_section.as_ref().map(|v| u32::try_from(v.addr).unwrap()).unwrap_or(0))?;
output_writter.write_u32::<LittleEndian>(self.dynsym_section.as_ref().map(|v| u32::try_from(v.size).unwrap()).unwrap_or(0))?;


This comment was generated by todo based on a TODO comment in 4d984ea in #41. cc @MegatonHammer.

@todo
Copy link

todo bot commented Apr 7, 2020

Module Name Offset

linkle/src/format/nxo.rs

Lines 435 to 438 in 4d984ea

// TODO: Module Name Offset
output_writter.write_u32::<LittleEndian>(0)?;
file_offset += compressed_code_size;


This comment was generated by todo based on a TODO comment in 4d984ea in #41. cc @MegatonHammer.

@todo
Copy link

todo bot commented Apr 7, 2020

Module Name Size

linkle/src/format/nxo.rs

Lines 448 to 451 in 4d984ea

// TODO: Module Name Size
output_writter.write_u32::<LittleEndian>(0)?;
file_offset += compressed_rodata_size;


This comment was generated by todo based on a TODO comment in 4d984ea in #41. cc @MegatonHammer.

@todo
Copy link

todo bot commented Apr 7, 2020

SegmentHeaderRelative for .api_info

linkle/src/format/nxo.rs

Lines 495 to 505 in 4d984ea

// TODO: SegmentHeaderRelative for .api_info
output_writter.write_u64::<LittleEndian>(0)?;
// SegmentHeaderRelative for .dynstr
output_writter.write_u32::<LittleEndian>(self.dynstr_section.as_ref().map(|v| u32::try_from(v.addr).unwrap()).unwrap_or(0))?;
output_writter.write_u32::<LittleEndian>(self.dynstr_section.as_ref().map(|v| u32::try_from(v.size).unwrap()).unwrap_or(0))?;
// SegmentHeaderRelative for .dynsym
output_writter.write_u32::<LittleEndian>(self.dynsym_section.as_ref().map(|v| u32::try_from(v.addr).unwrap()).unwrap_or(0))?;
output_writter.write_u32::<LittleEndian>(self.dynsym_section.as_ref().map(|v| u32::try_from(v.size).unwrap()).unwrap_or(0))?;
// .text sha256
let text_sum = utils::calculate_sha256(&code)?;


This comment was generated by todo based on a TODO comment in 4d984ea in #41. cc @MegatonHammer.

@roblabla roblabla marked this pull request as ready for review April 7, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant