Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios): 修复 iOS 编译 warning #498

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

isimple4
Copy link
Contributor

chore: 修复 iOS 编译 warning #458 #238
chore: 调整 iOS example 使用 pod 方式引入依赖
chore: 升级 Logan iOS target 到 9.0,升级 Pod 版本

@Richard-Cao
Copy link
Member

感谢贡献~
@wsxyeah 一起看看~

@wsxyeah
Copy link
Collaborator

wsxyeah commented Oct 9, 2023

我看这个 PR 主要是将 iOS Example 改为 Pod 方式依赖 clogan?

@isimple4
Copy link
Contributor Author

isimple4 commented Oct 9, 2023

我看这个 PR 主要是将 iOS Example 改为 Pod 方式依赖 clogan?

主要是修复了两个issue里提到的warning,顺便把 example 调整了下方便复现用户问题

@wsxyeah
Copy link
Collaborator

wsxyeah commented Oct 9, 2023

LGTM

@Richard-Cao Richard-Cao merged commit 3528c67 into Meituan-Dianping:master Oct 10, 2023
@Richard-Cao
Copy link
Member

我看这个 PR 主要是将 iOS Example 改为 Pod 方式依赖 clogan?

主要是修复了两个issue里提到的warning,顺便把 example 调整了下方便复现用户问题

哪两个issue,能引用一下么

@isimple4
Copy link
Contributor Author

我看这个 PR 主要是将 iOS Example 改为 Pod 方式依赖 clogan?

主要是修复了两个issue里提到的warning,顺便把 example 调整了下方便复现用户问题

哪两个issue,能引用一下么

嗯,是这两个,原文里也引用了,可能比较短😂
iOS pod 引入带入了.markdown文件 #458
iOS Pod 引入带来编译警告 #238

@isimple4 isimple4 deleted the feature/ios-project-fix branch March 1, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants