fix: add test for multiple identical schema messages #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visch
requested changes
Nov 1, 2023
pyproject.toml
Outdated
| @@ -33,7 +33,7 @@ packages = [ | |||
| [tool.poetry.dependencies] | |||
| python = "<3.12,>=3.7.1" | |||
| requests = "^2.25.1" | |||
| singer-sdk = ">=0.28,<0.34" | |||
| singer-sdk = ">=0.31,<0.34" | |||
There was a problem hiding this comment.
This is handled automatically by Depandabot PRs here we should probably just leave this be as I don't see a big value in bumping up the lower end of the singer-sdk range right now (Generally Poetry should just pull the latest SingerSDK version so maybe there's an argument for not having a range but that's pretty seperate
There was a problem hiding this comment.
My logic was that 0.31 is the version that merged meltano/sdk#1864 which was mentioned as a fix for #124. But if Dependabot is handling it, that makes sense.
sebastianswms
changed the title
visch
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK bumpPytest for multiple identical schema messages don't log "schema changed"
This doesn't directly address the problems in #124 because they have already been solved elsewhere. It merely ensures the tap uses an SDK version with the fix, and also adds a test to check that the behavior described in #124 won't happen again.
Closes #124