Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: raise exception if database doesnt exist #96

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

pnadolny13
Copy link
Contributor

Closes #78

I wanted to write a test to assert the exception gets raised and had a hard time fitting it into the test framework because by the time I receive the target in the test methods its already instantiated with the sample config with the valid database so I cant override it in an individual test. So I'd need to create a suite and call get_target_test_class just to run a single test, instead I just ran the components as a standalone test.

@pnadolny13 pnadolny13 merged commit 045b614 into main Jul 24, 2023
15 checks passed
@pnadolny13 pnadolny13 deleted the database_not_exists_error branch July 24, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Throw better error if database not found
2 participants