Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/na 250 #5

Merged
merged 7 commits into from
May 20, 2024
Merged

Test/na 250 #5

merged 7 commits into from
May 20, 2024

Conversation

SimaoBolota-MetaCell
Copy link
Contributor

Updates to the tests

  • Updated Max Volume rendering
  • Added Min Volume Rendering
  • Expanded 3D panel when taking snapshots of Max and Min Volume Rendering

@SimaoBolota-MetaCell
Copy link
Contributor Author

@seankmartin

I was getting errors on the last test step of the tests, related to the color map and the transfer function. The error was on the Shader and it said that there was no transferFunction function. So I marked as 'skip' the last step for each test.

What shader can I use that would allow me to unskip the last test step?

@seankmartin
Copy link
Contributor

Hey @SimaoBolota-MetaCell, this looks great! Thanks

Actually, the transferFunction tests might just work for you now, they were only recently merged into main so it might have just been bad timing. If it still doesn't work, let me know and I can help

@SimaoBolota-MetaCell
Copy link
Contributor Author

SimaoBolota-MetaCell commented May 20, 2024

Oh thanks @seankmartin I'll try now.
Changed the shader and now I was able to unskip the tests related to the colormap

@SimaoBolota-MetaCell SimaoBolota-MetaCell marked this pull request as draft May 20, 2024 09:30
@SimaoBolota-MetaCell

This comment was marked as resolved.

@SimaoBolota-MetaCell SimaoBolota-MetaCell marked this pull request as ready for review May 20, 2024 11:42
@SimaoBolota-MetaCell SimaoBolota-MetaCell requested review from seankmartin and removed request for seankmartin May 20, 2024 11:43
@seankmartin seankmartin merged commit 435bd84 into main May 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants