Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/na 356 Screenshot dialog UI #40

Merged
merged 34 commits into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
ce618d1
#NA-356 Screenshot Dialog UI updates
vidhya-metacell Oct 10, 2024
937a553
#NA-356 Screenshot Modal UI
vidhya-metacell Oct 11, 2024
d1457d9
#NA-356 PR comments update
vidhya-metacell Oct 17, 2024
12ad19d
#NA-356 PR updates
vidhya-metacell Oct 18, 2024
71bb1a8
#NA-356 Screenshot UI pr updates
vidhya-metacell Oct 21, 2024
f045680
feat: flip pixel and physical resolution
seankmartin Oct 28, 2024
b992557
chore: run fix formatting command for merge
seankmartin Oct 28, 2024
9a72905
fix: apply styling to children of screenshot menu
seankmartin Oct 28, 2024
302c119
Revert "fix: apply styling to children of screenshot menu"
seankmartin Oct 28, 2024
28bfb99
refactor: remove all svg files in local folder
seankmartin Oct 28, 2024
f8f39df
fix: help close positioning after using ikonate
seankmartin Oct 28, 2024
9647bd9
fix: apply styling to children of screenshot menu
seankmartin Oct 28, 2024
460d4d7
Revert "fix: apply styling to children of screenshot menu"
seankmartin Oct 28, 2024
c561ea8
fix: remove left right padding after ikonate usage on close button
seankmartin Oct 28, 2024
e03af09
refactor: combine same selector into one
seankmartin Oct 28, 2024
836fceb
fix: remove border on panel resolution table
seankmartin Oct 28, 2024
3441be2
fix: Panel type text not offset
seankmartin Oct 28, 2024
10e5548
Revert "fix: apply styling to children of screenshot menu"
seankmartin Oct 28, 2024
aba9956
Reapply "fix: apply styling to children of screenshot menu"
seankmartin Oct 28, 2024
d711bcf
feat: move body content to new div to help scroll feat
seankmartin Oct 29, 2024
e30b07d
feat: color dimension in screenshot
seankmartin Oct 29, 2024
50e240f
refactor: rename screenshot button
seankmartin Oct 29, 2024
4515da1
feat: add copy to clipboard resolution function
seankmartin Oct 29, 2024
024be79
fix: disable UI elements during screenshot
seankmartin Oct 29, 2024
f0efea9
feat: show forcing as status message
seankmartin Oct 29, 2024
5a1f605
fix: correct user screenshot force handling
seankmartin Oct 29, 2024
dce43eb
feat(python): support resolution scale factor in CLI
seankmartin Oct 29, 2024
045d9cf
NA-362-screenshot scrollbar change style
Aiga115 Nov 1, 2024
e0d81bf
NA-362-screenshot fix tooltip ui and table ui
Aiga115 Nov 5, 2024
92af1f2
feat: small changes and revert scroll bar styling
seankmartin Nov 6, 2024
4b9b04e
Merge pull request #46 from MetaCell/feature/NA-362-screenshot
seankmartin Nov 6, 2024
cde708e
Merge pull request #44 from MetaCell/feature/screenshot-cli-scale
seankmartin Nov 6, 2024
e952d59
Merge branch 'feature/NA-362' into feature/NA-356
seankmartin Nov 6, 2024
34672e1
feat: use :is in css to restrict changes
seankmartin Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/neuroglancer/tool/screenshot.py
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,11 @@ def define_state_modification_args(ap: argparse.ArgumentParser):
type=float,
help="Multiply projection view scale by specified factor.",
)
ap.add_argument(
"--resolution-scale-factor",
type=float,
help="Divide cross section view scale by specified factor. E.g. a 2000x2000 output with a resolution scale factor of 2 will have the same FOV as a 1000x1000 output.",
)
ap.add_argument(
"--system-memory-limit",
type=int,
Expand All @@ -621,7 +626,6 @@ def define_state_modification_args(ap: argparse.ArgumentParser):
"--scale-bar-scale", type=float, help="Scale factor for scale bar", default=1
)


def apply_state_modifications(
state: neuroglancer.ViewerState, args: argparse.Namespace
):
Expand All @@ -635,6 +639,8 @@ def apply_state_modifications(
state.show_default_annotations = args.show_default_annotations
if args.projection_scale_multiplier is not None:
state.projection_scale *= args.projection_scale_multiplier
if args.resolution_scale_factor is not None:
state.cross_section_scale /= args.resolution_scale_factor
if args.cross_section_background_color is not None:
state.cross_section_background_color = args.cross_section_background_color

Expand Down
Loading
Loading