Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/na 356 changes #42

Open
wants to merge 10 commits into
base: feature/NA-356
Choose a base branch
from
Open

Conversation

seankmartin
Copy link

Changes:

  1. Removes all the svg files that are not from ikonate
  2. Small changes in the css to account for change 1 upsetting some padding and margins
  3. Remove the border on the right and left from the panel resolution table (the layer resolution table already had this)
  4. Small refactor in CSS
  5. More specific usage in CSS for the elements as they were bleeding through to main neuroglancer. Use :is for this, but open to suggestions.

image

@seankmartin
Copy link
Author

For me, one change is not showing in the PR review, so just in case. I changed the div span... selector to use :is because they were bleeding through to regular neuroglancer div and span etc. elements without it. Let me know if you have another suggestion!

.neuroglancer-screenshot-overlay
  :is(
    div,
    span,
    a,
    img,
    h1,
    h2,
    h3,
    h4,
    h5,
    h6,
    p,
    form,
    input,
    textarea,
    select,
    strong,
    table,
    tr,
    td,
    th,
    tbody,
    button
  ) {
  box-sizing: border-box;
  outline: 0;
}

@seankmartin seankmartin marked this pull request as ready for review October 28, 2024 16:44
Copy link

@vidhya-metacell vidhya-metacell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seankmartin everything looks good,
for the :is, I usually do .classname * { } like this, but if it reflecting the css then great, no issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants