Skip to content

Commit

Permalink
Update changelog with v4.0.x releases (#76)
Browse files Browse the repository at this point in the history
* Don't fail overall if Slack announcement fails (#69)

Typically, for a project, this action is run twice: once in dry-run mode
(to allow approvers to review the package before it is published) and
another time to issue the approval step and then actually publish the
package.

When the action is run in dry-run mode, an announcement on Slack is
created in order to notify approvers. If this fails in any way, however,
it halts the release workflow completely and prevents the second
instance of the action from running. This means that the package can
never be released automatically and must be released manually.

This commit fix this problem by instructing GitHub Actions that it is
not mandatory for the Slack announcement step to pass in order for the
release workflow to continue.

* Release 4.0.2 (#72)

* remove default channel (#73)

* Release 4.0.3

* fix: Fix action manifest validation error (#77)

The action manifest used the id `slack` for two steps, which is not
allowed. We don't reference this id anywhere, so it has been removed.

* Release 4.0.4 (#78)

---------

Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: ricky <[email protected]>
  • Loading branch information
3 people authored May 10, 2024
1 parent c92e153 commit 2d0ccb5
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fix Yarn 4 compatibility ([#65](https://github.com/MetaMask/action-npm-publish/pull/65))

## [4.0.4]
### Fixed
- Fix action validation error ([#77](https://github.com/MetaMask/action-npm-publish/pull/77))

## [4.0.3]
### Fixed
- Fix Slack announcement for public default channel ([#73](https://github.com/MetaMask/action-npm-publish/pull/73))
- We have found that the Slack announcement does not work correctly for public channels when the `channel` parameter is given. The action has been updated to omit the default if no channel is specified, so that announcements to the default channel work correctly even if it is public.

## [4.0.2]
### Fixed
- Prevent workflow from failing if Slack announcement step fails ([#69](https://github.com/MetaMask/action-npm-publish/pull/69))
- Within the context of a project, the Slack announcement message that is posted after running this workflow in dry-run mode is not crucial, and thus this change ensures that the package will still be published for real if this step fails.

## [4.0.1]
### Changed
- Use tag to check latest package version ([#51](https://github.com/MetaMask/action-npm-publish/pull/51))
Expand Down Expand Up @@ -82,7 +96,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Initial release ([#1](https://github.com/MetaMask/action-npm-publish/pull/1))

[Unreleased]: https://github.com/MetaMask/action-npm-publish/compare/v5.0.0...HEAD
[5.0.0]: https://github.com/MetaMask/action-npm-publish/compare/v4.0.1...v5.0.0
[5.0.0]: https://github.com/MetaMask/action-npm-publish/compare/v4.0.4...v5.0.0
[4.0.4]: https://github.com/MetaMask/action-npm-publish/compare/v4.0.3...v4.0.4
[4.0.3]: https://github.com/MetaMask/action-npm-publish/compare/v4.0.2...v4.0.3
[4.0.2]: https://github.com/MetaMask/action-npm-publish/compare/v4.0.1...v4.0.2
[4.0.1]: https://github.com/MetaMask/action-npm-publish/compare/v4.0.0...v4.0.1
[4.0.0]: https://github.com/MetaMask/action-npm-publish/compare/v3.2.0...v4.0.0
[3.2.0]: https://github.com/MetaMask/action-npm-publish/compare/v3.1.1...v3.2.0
Expand Down

0 comments on commit 2d0ccb5

Please sign in to comment.