Skip to content

Commit

Permalink
Don't fail overall if Slack announcement fails (#69)
Browse files Browse the repository at this point in the history
Typically, for a project, this action is run twice: once in dry-run mode
(to allow approvers to review the package before it is published) and
another time to issue the approval step and then actually publish the
package.

When the action is run in dry-run mode, an announcement on Slack is
created in order to notify approvers. If this fails in any way, however,
it halts the release workflow completely and prevents the second
instance of the action from running. This means that the package can
never be released automatically and must be released manually.

This commit fix this problem by instructing GitHub Actions that it is
not mandatory for the Slack announcement step to pass in order for the
release workflow to continue.
  • Loading branch information
mcmire authored May 8, 2024
1 parent 0e5aa50 commit 2f74132
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,4 @@ runs:
env:
SLACK_WEBHOOK_URL: ${{ inputs.slack-webhook-url }}
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
continue-on-error: true

0 comments on commit 2f74132

Please sign in to comment.