Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail overall if Slack announcement fails #69

Merged
merged 1 commit into from
May 8, 2024

Commits on May 7, 2024

  1. Don't fail overall if Slack announcement fails

    Typically, for a project, this action is run twice: once in dry-run mode
    (to allow approvers to review the package before it is published) and
    another time to issue the approval step and then actually publish the
    package.
    
    When the action is run in dry-run mode, an announcement on Slack is
    created in order to notify approvers. If this fails in any way, however,
    it halts the release workflow completely and prevents the second
    instance of the action from running. This means that the package can
    never be released automatically and must be released manually.
    
    This commit fix this problem by instructing GitHub Actions that it is
    not mandatory for the Slack announcement step to pass in order for the
    release workflow to continue.
    mcmire committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d686366 View commit details
    Browse the repository at this point in the history