Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing configuration for non-default Slack channel messages #81

Merged
merged 1 commit into from
May 14, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented May 14, 2024

Following recent changes it was no longer possible to use this action with a non-default Slack channel as the target for the messages.

Any attempt to use the action would fail with: Error: Need to provide at least one botToken or webhookUrl

This PR fixes this by re-adding the required configuration to the action.

@FrederikBolding FrederikBolding requested a review from a team as a code owner May 14, 2024 10:27
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding FrederikBolding merged commit 272ea69 into main May 14, 2024
12 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-non-default-channel branch May 14, 2024 11:58
FrederikBolding added a commit that referenced this pull request May 14, 2024
* fix: add missing configuration for non-default Slack channel messages (#81)

* v4.0.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants