Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move update to sub-command #26

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Move update to sub-command #26

merged 1 commit into from
Apr 20, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 20, 2021

The "update" action has been moved to a sub-command, in preparation for adding more commands in later PRs. Specifying a command has been made mandatory.

The update-changelog npm script has been renamed to changelog, to reflect that it will soon be used for more than just updates.

@Gudahtt Gudahtt requested a review from a team as a code owner April 20, 2021 13:27
@Gudahtt Gudahtt force-pushed the move-update-to-subcommand branch 2 times, most recently from 6631076 to def1d77 Compare April 20, 2021 15:03
@Gudahtt Gudahtt mentioned this pull request Apr 20, 2021
The "update" action has been moved to a sub-command, in preparation
for adding more commands in later PRs. Specifying a command has been
made mandatory.

The `update-changelog` npm script has been renamed to `changelog`, to
reflect that it will soon be used for more than just updates.
Copy link

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all jokes aside LGTM

.strict()
.demandCommand()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JUST TELL ME WHAT TO DO! I demand your command.

@Gudahtt Gudahtt merged commit d3a74e4 into main Apr 20, 2021
@Gudahtt Gudahtt deleted the move-update-to-subcommand branch April 20, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants