Add root parameter
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `root` parameter allows specifying the root project directory. This is used to resolve the changelog file path (unless an absolute path is specified), and it's used by the `update` command to ensure the search for changes since the last release only includes changes in the given root directory. This new option is exposed via the API only on the `update` function, with the `rootProjectDirectory` option. This was the last feature required for monorepo support. Closes #34
rekmarks
previously approved these changes
May 3, 2021
| console.error( | ||
| `Project root must be a directory: '${projectRootDirectory}'`, | ||
| ); | ||
| process.exit(1); |
There was a problem hiding this comment.
This is probably out of scope for this PR, but I recently realized how strongly Node advises against the log-and-process.exit pattern: https://nodejs.org/api/process.html#process_process_exit_code
Going through snaps-cli and getting rid of 17 cases of the same is on my TODO-list 😑
There was a problem hiding this comment.
TIL. Easy enough to avoid this pattern in this case at least. I can fix this in a follow-up PR.
If `root` was set on the CLI, it wasn't being properly passed through to the `update` function.
|
Found a couple of silly mistakes in further testing - see the newest two commits. |
rekmarks
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rootparameter allows specifying the root project directory. This is used to resolve the changelog file path (unless an absolute path is specified), and it's used by theupdatecommand to ensure the search for changes since the last release only includes changes in the given root directory.This new option is exposed via the API only on the
updatefunction, with therootProjectDirectoryoption.This was the last feature required for monorepo support.
Closes #34