Migrate to TypeScript #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
commented
May 17, 2021
rekmarks
commented
May 17, 2021
rekmarks
commented
May 17, 2021
rekmarks
commented
May 17, 2021
rekmarks
commented
May 17, 2021
Gudahtt
reviewed
May 18, 2021
Gudahtt
reviewed
May 18, 2021
Gudahtt
reviewed
May 18, 2021
Gudahtt
reviewed
May 18, 2021
Gudahtt
reviewed
May 18, 2021
Co-authored-by: Mark Stacey <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
Gudahtt
reviewed
May 19, 2021
Gudahtt
reviewed
May 19, 2021
Gudahtt
reviewed
May 19, 2021
* Handle undefined newChangelogContent in CLI update function Co-authored-by: Mark Stacey <[email protected]>
Gudahtt
reviewed
May 19, 2021
Co-authored-by: Mark Stacey <[email protected]>
Gudahtt
reviewed
May 19, 2021
| * Represents a formatting error in a changelog. | ||
| */ | ||
| export class ChangelogFormattingError extends InvalidChangelogError { | ||
| public data: Record<string, string>; |
There was a problem hiding this comment.
Curious that in cli.ts, when this is referenced, it's able to infer that it has entries for validChangelog and invalidChangelog 🤔 I don't quite follow how it knows those properties exist. Some kinda fancy type inference maybe.
Gudahtt
reviewed
May 19, 2021
rekmarks
commented
May 19, 2021
src/parseChangelog.ts
Outdated
Comment on lines
114
to
115
| // TODO: Get rid of typecast? | ||
| mostRecentCategory = results[1] as ChangeCategory; |
There was a problem hiding this comment.
Curious about your thoughts here. I don't think we can be certain that this will be a valid change category?
There was a problem hiding this comment.
Yeah, you're right. I think we should check, and throw if it's invalid.
Gudahtt
reviewed
May 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the whole project to TypeScript. Care has been taken to change as little as possible, but in some places I had to add behavior-altering code to please
tsc.At the time of writing, there are a handful of type-related, outstanding TODOs, which I've highlighted with inline comments.