Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store key derivation function used and iteration count in payload #1

Open
federicobond opened this issue Jun 29, 2017 · 3 comments · May be fixed by #33
Open

Store key derivation function used and iteration count in payload #1

federicobond opened this issue Jun 29, 2017 · 3 comments · May be fixed by #33

Comments

@federicobond
Copy link

The KDF used and iteration count should be included in the payload returned from encrypt to facilitate upgrades over time. This makes it possible to change the work factor or the algorithm used without breaking backward compatibility.

Library users should be encouraged to upgrade encrypted ciphertexts from time to time to take advantage of this too.

@danfinlay
Copy link
Contributor

I agree, and plan to do this eventually, maybe using pojo-migrator to allow users of the old format to experience no breaking changes.

In the meanwhile, I wouldn't object to a PR that does this, especially if it had a non-breaking migration process from the old format.

@federicobond
Copy link
Author

We can always assume the current values if there aren't any defined, to preserve backwards compatibility.

@danfinlay
Copy link
Contributor

Exactly.

danfinlay pushed a commit that referenced this issue Jul 16, 2021
@Gudahtt Gudahtt linked a pull request Nov 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants