Fix detectTokens to remove redundant TokensController:getState ca…

…lls for `ignoredTokens`
MetaMask · Feb 6, 2024 · 8f21fc8 · 8f21fc8
1 parent f47a4ce
commit 8f21fc8
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/packages/assets-controllers/src/TokenDetectionController.ts b/packages/assets-controllers/src/TokenDetectionController.ts
@@ -465,7 +465,9 @@ export class TokenDetectionController extends StaticIntervalPollingController<
       ? STATIC_MAINNET_TOKEN_LIST
       : tokenList;
 
-    const { tokens, detectedTokens } = this.#getTokensState();
+    const { tokens, detectedTokens, ignoredTokens } = this.messagingSystem.call(
+      'TokensController:getState',
+    );
     const tokensToDetect: string[] = [];
 
     for (const tokenAddress of Object.keys(tokenListUsed)) {
@@ -505,11 +507,9 @@ export class TokenDetectionController extends StaticIntervalPollingController<
           tokensSlice,
         );
         const tokensToAdd: Token[] = [];
-        const eventTokensDetails = [];
+        const eventTokensDetails: string[] = [];
+        let ignored;
         for (const tokenAddress of Object.keys(balances)) {
-          let ignored;
-          /* istanbul ignore else */
-          const { ignoredTokens } = this.#getTokensState();
           if (ignoredTokens.length) {
             ignored = ignoredTokens.find(
               (ignoredTokenAddress) =>
@@ -524,7 +524,7 @@ export class TokenDetectionController extends StaticIntervalPollingController<
 
           if (ignored === undefined) {
             const { decimals, symbol, aggregators, iconUrl, name } =
-              tokenList[caseInsensitiveTokenKey];
+              tokenListUsed[caseInsensitiveTokenKey];
             eventTokensDetails.push(`${symbol} - ${tokenAddress}`);
             tokensToAdd.push({
               address: tokenAddress,