Skip to content

Commit

Permalink
Add missing changelog entries
Browse files Browse the repository at this point in the history
- Add changelog entries for transaction-controller
- Bump transaction-controller to 14.0.0
- Add changelog entries for assets-controllers
  • Loading branch information
mcmire committed Oct 4, 2023
1 parent 240f550 commit f5a6dc5
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 25 deletions.
45 changes: 24 additions & 21 deletions packages/assets-controllers/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,40 +9,43 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [15.0.0]
### Changed
- **BREAKING**: `NftController` now expects `getNetworkClientById` in constructor options ([#1698](https://github.com/MetaMask/core/pull/1698))
- **BREAKING**: `NftController.addNft()` function signature has changed ([#1698](https://github.com/MetaMask/core/pull/1698))
- **BREAKING**: `NftController.addNft` function signature has changed ([#1698](https://github.com/MetaMask/core/pull/1698))
- Previously
```
address: string,
tokenId: string,
nftMetadata?: NftMetadata,
accountParams?: {
userAddress: string;
chainId: Hex;
},
source = Source.Custom,
address: string,
tokenId: string,
nftMetadata?: NftMetadata,
accountParams?: {
userAddress: string;
chainId: Hex;
},
source = Source.Custom,
```
now:
now:
```
tokenAddress: string,
tokenId: string,
{
nftMetadata?: NftMetadata;
chainId?: Hex; // extracts from AccountParams
userAddress?: string // extracted from AccountParams
source?: Source;
networkClientId?: NetworkClientId; // new
},
tokenAddress: string,
tokenId: string,
{
nftMetadata?: NftMetadata;
chainId?: Hex; // extracts from AccountParams
userAddress?: string // extracted from AccountParams
source?: Source;
networkClientId?: NetworkClientId; // new
},
```
- `NftController.addNftVerifyOwnership`: Now accepts optional 3rd argument `networkClientId` which is used to fetch NFT metadata and determine by which chainId the added NFT should be stored in state. Also accepts optional 4th argument `source` used for metrics to identify the flow in which the NFT was added to the wallet. ([#1698](https://github.com/MetaMask/core/pull/1698))
- `NftController.isNftOwner`: Now accepts optional `networkClientId` which is used to instantiate the provider for the correct chain and call the NFT contract to verify ownership ([#1698](https://github.com/MetaMask/core/pull/1698))
- `NftController.addNft()` will use the chainId value derived from `networkClientId` if provided ([#1698](https://github.com/MetaMask/core/pull/1698))
- `NftController.watchNft()` options now accepts optional `networkClientId` which is used to fetch NFT metadata and determine by which chainId the added NFT should be stored in state ([#1698](https://github.com/MetaMask/core/pull/1698))
- `NftController.addNft` will use the chainId value derived from `networkClientId` if provided ([#1698](https://github.com/MetaMask/core/pull/1698))
- `NftController.watchNft` options now accepts optional `networkClientId` which is used to fetch NFT metadata and determine by which chainId the added NFT should be stored in state ([#1698](https://github.com/MetaMask/core/pull/1698))
- Bump dependency on `@metamask/utils` to ^8.1.0 ([#1639](https://github.com/MetaMask/core/pull/1639))
- Bump dependency and peer dependency on `@metamask/approval-controller` to ^4.0.0
- Bump dependency on `@metamask/base-controller` to ^3.2.3
- Bump dependency on `@metamask/controller-utils` to ^5.0.2
- Bump dependency and peer dependency on `@metamask/network-controller` to ^14.0.0

### Fixed
- Fix bug in TokensController where batched `addToken` overwrote each other because mutex was acquired after reading state ([#1768](https://github.com/MetaMask/core/pull/1768))

## [14.0.0]
### Changed
- Update TypeScript to v4.8.x ([#1718](https://github.com/MetaMask/core/pull/1718))
Expand Down
24 changes: 21 additions & 3 deletions packages/transaction-controller/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,32 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [13.0.1]
## [14.0.0]
### Added
- **BREAKING:** Add required `getPermittedAccounts` argument to constructor, used to validate `from` addresses ([#1722](https://github.com/MetaMask/core/pull/1722))
- Add `securityProviderRequest` option to constructor ([#1725](https://github.com/MetaMask/core/pull/1725))
- Add `method` option to `addTransaction` method ([#1725](https://github.com/MetaMask/core/pull/1725))
- Add `securityProviderRequest` property to TransactionMetaBase ([#1725](https://github.com/MetaMask/core/pull/1725))
- Add SecurityProviderRequest type ([#1725](https://github.com/MetaMask/core/pull/1725))
- Update `addTransaction` to set `securityProviderRequest` on transaction metadata when requested to do so ([#1725](https://github.com/MetaMask/core/pull/1725))
- Update `txParams` validation to validate `chainId` ([#1723](https://github.com/MetaMask/core/pull/1723))
- Update `addTransaction` to ensure allowed `from` address when `origin` is specified ([#1722](https://github.com/MetaMask/core/pull/1722))

### Changed
- Bump dependency on `@metamask/utils` to ^8.1.0 ([#1639](https://github.com/MetaMask/core/pull/1639))
- Bump dependency and peer dependency on `@metamask/approval-controller` to ^4.0.0
- Bump dependency on `@metamask/base-controller` to ^3.2.3
- Bump dependency on `@metamask/controller-utils` to ^5.0.2
- Bump dependency and peer dependency on `@metamask/network-controller` to ^14.0.0

### Removed
- **BREAKING:** Remove `interval` config option ([#1746](https://github.com/MetaMask/core/pull/1746))
- The block tracker (which has its own interval) is now used to poll for pending transactions instead.
- **BREAKING:** Remove `poll` method ([#1746](https://github.com/MetaMask/core/pull/1746))
- The block tracker is assumed to be running, TransactionController does not offer a way to stop it.
- **BREAKING:** Remove `queryTransactionStatuses` method ([#1746](https://github.com/MetaMask/core/pull/1746))
- This functionality has been moved to a private interface and there is no way to use it externally.

## [13.0.0]
### Changed
- **BREAKING**: Add required `getCurrentAccountEIP1559Compatibility` and `getCurrentNetworkEIP1559Compatibility` callback arguments to constructor ([#1693](https://github.com/MetaMask/core/pull/1693))
Expand Down Expand Up @@ -219,8 +237,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

All changes listed after this point were applied to this package following the monorepo conversion.

[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@13.0.1...HEAD
[13.0.1]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/transaction-controller@13.0.1
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/transaction-controller@14.0.0...HEAD
[14.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/transaction-controller@14.0.0
[13.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected]
[12.0.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected]
[11.1.0]: https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion packages/transaction-controller/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@metamask/transaction-controller",
"version": "13.0.1",
"version": "14.0.0",
"description": "Stores transactions alongside their periodically updated statuses and manages interactions such as approval and cancellation",
"keywords": [
"MetaMask",
Expand Down

0 comments on commit f5a6dc5

Please sign in to comment.