Update Preferences state #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 889 889
Branches 97 97
=====================================
Hits 889 889
Continue to review full report at Codecov.
|
3 tasks
rickycodes
added a commit
that referenced
this pull request
Nov 23, 2022
* 32.0.3 * update changelog * use marjor Co-authored-by: github-actions <[email protected]> Co-authored-by: Ricky Miller <[email protected]>
mcmire
added a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
Bump TypeScript and fix compile errors. Specifically, an error that's caught is now typed as `unknown`, so accessing `message` on that error object won't work anymore. This is fixed using a type guard. Also bump `typedoc` to fix peer dependency warnings.
MajorLift
pushed a commit
that referenced
this pull request
Sep 22, 2023
--------- Co-authored-by: github-actions <[email protected]> Co-authored-by: legobt <[email protected]>
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
* 5.1.6; update batch request handling * remove Promise wrapping * simplify _handleBatch implementation * add clarifying comments * standardize internal errors Co-authored-by: Dan Finlay <[email protected]>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some Preferences Controller state updating inside GABA but not in the general state.