CurrencyRatesController: add baseAsset support #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 889 891 +2
Branches 97 97
=====================================
+ Hits 889 891 +2
Continue to review full report at Codecov.
|
bitpshr
force-pushed
the
currency-rates-cleanup
branch
2 times, most recently
from
c71b81f
to
f93194e
Compare
bitpshr
force-pushed
the
currency-rates-cleanup
branch
from
f93194e
to
f3024ad
Compare
whymarrh
reviewed
Nov 27, 2018
src/CurrencyRateController.test.ts
Outdated
| const baseAsset = 'FOO'; | ||
| const controller = new CurrencyRateController({ baseAsset }); | ||
| const mock = stub(window, 'fetch'); | ||
| (window.fetch as SinonStub).returns( |
There was a problem hiding this comment.
Can we use mock here instead of casting window.fetch? mock should have .returns on it, I think.
Also we might be able to use .resolves(x) instead of .returns(Promise.resolve(x)) here.
brunobar79
reviewed
Nov 27, 2018
| "percentile": "^1.2.1", | ||
| "uuid": "^3.3.2", |
There was a problem hiding this comment.
I couldn't find where you are using this dep. in this PR
There was a problem hiding this comment.
We were missing it, it's used in TransactionController.
bitpshr
force-pushed
the
currency-rates-cleanup
branch
from
90b9038
to
c9e55e0
Compare
brunobar79
approved these changes
Nov 27, 2018
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
* 3.0.3 * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: github-actions <[email protected]> Co-authored-by: Maarten Zuidhoorn <[email protected]>
kanthesha
pushed a commit
that referenced
this pull request
Sep 19, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request cleans up
CurrencyRatesControllerand adds support for a new configuration parameter:baseAsset.