Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[assets-contract-controller] Apply messenger pattern and remove inheritance from BaseControllerV1 #4397

Merged
merged 44 commits into from
Jul 19, 2024
Merged

[assets-contract-controller] Apply messenger pattern and remove inheritance from BaseControllerV1 #4397

merged 44 commits into from
Jul 19, 2024
+1,137 −795

Commits on Jul 16, 2024

  1. Convert AssetsContractController to use messenger pattern without i… 

    …nheriting from `BaseControllerV2`
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5288605 View commit details
    Browse the repository at this point in the history

  2. Fix method returning promise into async function

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7886280 View commit details
    Browse the repository at this point in the history

  3. Explicitly enumerate package-level exports

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7b2ed46 View commit details
    Browse the repository at this point in the history

  4. Adapt tests to use messenger pattern

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fa059a9 View commit details
    Browse the repository at this point in the history

  5. Narrow iindex signature of SINGLE_CALL_BALANCES_ADDRESS_BY_CHAINID

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    27f6f88 View commit details
    Browse the repository at this point in the history

  6. Define messenger actions corresponding to the public methods of `Asse… 

    …tsContractController`
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c6a9323 View commit details
    Browse the repository at this point in the history

  7. Convert getters for provider, chainId into private methods

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    35a3bf9 View commit details
    Browse the repository at this point in the history

  8. Register action handlers

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4c37cfe View commit details
    Browse the repository at this point in the history

  9. Replace AssetsContractController constructor options with messenger a… 

    …ctions in downstream controllers
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    79a29c3 View commit details
    Browse the repository at this point in the history

  10. Linter fix

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1315c88 View commit details
    Browse the repository at this point in the history

  11. Convert class methods into messenger actions

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    83271e7 View commit details
    Browse the repository at this point in the history

  12. Register class methods as action handlers

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    123fe80 View commit details
    Browse the repository at this point in the history

  13. Add assets-contract actions as allowed actions to downstream controllers

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ee3a923 View commit details
    Browse the repository at this point in the history

  14. [assets-contract] Adjust downstream tests to use messenger actions in… 

    …stead of class method callbacks
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    10a4678 View commit details
    Browse the repository at this point in the history

  15. Pass callbacks into expect

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    39ac871 View commit details
    Browse the repository at this point in the history

  16. Fix setupAssetContractControllers so that `useNetworkControllerProv… 

    …ider` option works
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3964cb1 View commit details
    Browse the repository at this point in the history

  17. Make class fields accessible but immutable by converting to private b… 

    …ut exposing getter
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    079f4cd View commit details
    Browse the repository at this point in the history

  18. fix NftController test mock action handlers to be excluded from `op… 

    …tions` bag
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f1f58e7 View commit details
    Browse the repository at this point in the history

  19. Replace references to NetworkController:stateChange event with `Net… 

    …workController:networkDidChange` event
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2de5258 View commit details
    Browse the repository at this point in the history

  20. Fix #getCorrect{Provider,ChainId} methods so that the methods retur… 

    …n up-to-date results by referencing the currently selected network in the network-controller, even if the `networkClientId` param is omitted.
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    69ba701 View commit details
    Browse the repository at this point in the history

  21. Fix setupAssetContractControllers, revert unintended changes to `us… 

    …eNetworkControllerProvider` flag behavior
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a258fa2 View commit details
    Browse the repository at this point in the history

  22. Clean up AssetsContractController tests

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    bbb0b0f View commit details
    Browse the repository at this point in the history

  23. Fix BN.isZero() call that throws error, causing ERC-1155 ownership … 

    …check to return exception
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    30d2f29 View commit details
    Browse the repository at this point in the history

  24. Fix NftController watchNft test errors caused by changes to `mess… 

    …enger.call` invocation order
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    38fb163 View commit details
    Browse the repository at this point in the history

  25. Set ApprovalController:addRequest payload `requestData.asset.standa… 

    …rd` property fallback value to `suggestedNftMeta.type`
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1559242 View commit details
    Browse the repository at this point in the history

  26. Fix async expect.rejects.toThrow call so that the expect call is … 

    …synchronous and its argument is an async callback
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ed70562 View commit details
    Browse the repository at this point in the history

  27. Update coverage thresholds

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ffa8cb3 View commit details
    Browse the repository at this point in the history

  28. Add eslint-disable directive to prevent test from timing out

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    022b3ff View commit details
    Browse the repository at this point in the history

  29. Adapt watchNft tests to new messenger call invocations 

    - Explicitly mock all messenger call invocation results
- Fix results for `'should handle ERC721 type and add pending request to ApprovalController with the OpenSea API enabled and IPFS gateway disabled'` test based on fully mocked return values
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    18cc886 View commit details
    Browse the repository at this point in the history

  30. Use getKnownPropertyNames for iterative registerActionHandlers logic

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c445384 View commit details
    Browse the repository at this point in the history

  31. Revert unnecessary changes

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    056e8dc View commit details
    Browse the repository at this point in the history

  32. Remove unreleased changelog entries

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    99fc5b9 View commit details
    Browse the repository at this point in the history

  33. Convert provider setter into setProvider method

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6c6f6e5 View commit details
    Browse the repository at this point in the history

  34. Add jsdoc for AssetsContractController types

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    20e5451 View commit details
    Browse the repository at this point in the history

  35. Fix #registerActionHandlers 

    - Restore usage of `Object.getPrototypeOf`
- add `setProvider` to exceptions
    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1d5ea66 View commit details
    Browse the repository at this point in the history

  36. test(nft-controller): fix messenger call mocks

    @MajorLift
    MajorLift committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    236844a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. test(nft-controller): expose mock constructors for allowedActions

    @MajorLift
    MajorLift committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a40f0d1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 240610-upgrade-AssetsContractController

    @MajorLift
    MajorLift committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    161b7ce View commit details
    Browse the repository at this point in the history

  3. Rename variable for clarity 

    Co-authored-by: Elliot Winkler <[email protected]>
    @MajorLift
    MajorLift and Elliot Winkler committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f50e5f4 View commit details
    Browse the repository at this point in the history

  4. Remove getter for provider

    @MajorLift
    MajorLift committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    418df79 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 240610-upgrade-AssetsContractController

    @MajorLift
    MajorLift authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c35943c View commit details
    Browse the repository at this point in the history

  6. Apply ExtractAvailable{Action,Event} test utility types 

    Co-authored-by: Elliot Winkler <[email protected]>
    @MajorLift @mcmire
    MajorLift and mcmire committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    49831d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge branch 'main' into 240610-upgrade-AssetsContractController

    @MajorLift
    MajorLift authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e6324d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge branch 'main' into 240610-upgrade-AssetsContractController

    @MajorLift
    MajorLift authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b496b69 View commit details
    Browse the repository at this point in the history