feat: add call to getCollection to get more collection data #4443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergeron
reviewed
Jun 25, 2024
bergeron
reviewed
Jun 25, 2024
bergeron
reviewed
Jun 25, 2024
salimtb
reviewed
Jun 27, 2024
bergeron
previously approved these changes
Jun 27, 2024
salimtb
reviewed
Jun 27, 2024
sahar-fehri
force-pushed
the
feat/call-get-collections-v2
branch
from
d0c49fd
to
5eb7be9
Compare
sahar-fehri
commented
Jul 2, 2024
| const collections = apiNfts.reduce<string[]>((acc, currValue) => { | ||
| if ( | ||
| !acc.includes(currValue.token.contract) && | ||
| currValue.token.contract === currValue?.token?.collection?.id |
There was a problem hiding this comment.
Pushing only when token.contract is equal collection.id which will exclude cases of shared contract addresses where collection.id can be equal "0xaddress...:1234:3445".
This can change in future to support these contracts once NFT-API also supports it 🙏
salimtb
previously approved these changes
Jul 9, 2024
7 tasks
mcmire
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Overall I don't have many comments here, just a couple of nitpicks. I do notice a lot of checks for the existence of various properties and it might make the code easier to work with if we figured out a way to remove those (i.e. if we handled filling in default values at some earlier point in the process). But, I am not 100% familiar with this code so I'm not sure how feasible that is.
salimtb
approved these changes
Jul 10, 2024
sahar-fehri
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jul 16, 2024
## **Description** PR that updates the design for the NFT page. Designs are here: https://www.figma.com/design/TfVzSMJA8KwpWX8TTWQ2iO/Asset-list-and-details?node-id=3717-47944&m=dev [](https://codespaces.new/MetaMask/metamask-extension/pull/25524?quickstart=1) ## **Related issues** Fixes: Related: MetaMask/core#4443 ## **Manual testing steps** 1. Go to NFT tab 2. Click on any NFT you have 3. You should be able to see the new NFT page with no errors even if some data is not available. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-extension/assets/10994169/dc6ca128-5f2a-45e2-9289-d84f5403d772 ### **After** https://github.com/MetaMask/metamask-extension/assets/10994169/58fd8cd4-24d9-42e9-931a-c33f8ae812d6 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]>
sahar-fehri
added a commit
that referenced
this pull request
Jul 16, 2024
## Explanation Releases assets-controllers to new version `36.0.0` ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? For example: * Fixes #12345 * Related to #67890 --> ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/assets-controllers` ### Added - **Added**: Add optional `topBid` property to the `NftMetadata` type. This property must be of type `TopBid`. ([#4522](#4522)) - **Added**: Add optional `floorAsk` property to the `TokenCollection` type. This property must be of type `FloorAskCollection`. ([#4522](#4522)) - **Added**: Add linea mainnet support to nft detection supported networks ([#4515](#4515)) - **Added**: Fetch NFT collections data from the NFT-API `getCollections` API when calling the `detectNfts` method of `NftDetectionController`, and the `updateNftMetadata` and `watchNft` methods of `NftController`. ([#4443](#4443)) ### Changed - **Changed**: Bump `@metamask/utils` to `^9.0.0` ([#4508](#4516)) - **Changed**: Bump `@metamask/rpc-errors` to `^6.3.1` ([#4498](#4516)) ### Fixed - **Breaking**: Changed attributes type in `NftMetadata` to `Attributes[]` ([#4522](#4522)) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
7 tasks
sahar-fehri
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Aug 1, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/25524?quickstart=1){kind=link}
## **Description** This PR modifies the design of the NFT details page. Designs: https://www.figma.com/design/TfVzSMJA8KwpWX8TTWQ2iO/Asset-list-and-details?node-id=1242-143952&m=dev ## **Related issues** Fixes: Related: MetaMask/core#4522 Related: MetaMask/core#4443 ## **Manual testing steps** 1. Go to this NFT tab 2. Click and browse through your NFTs 3. You should be able to see basic things like tokenId, contract address, description. Other fields will be displayed if they exist. 4. Click on the contract address and you should be redirected to etherscan. 5. Click on the image in the NFT details page and you should see the image in a new page without any of the details. 6. Try clicking on the navbar and go to "See on opensea" 7. Removing NFT flow and Sending NFT flow should not be affected ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/97679ba6-c8bb-483d-adb1-f3ebfdfb4337 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/024f389a-9feb-4fef-8b20-81fa59f232fd Also we added a new bottom sheet when token ID is too long https://github.com/user-attachments/assets/1434b08b-ab1a-4e56-acde-189b303b88e9 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Curtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We wanted to fetch more collection related data to populate the new NFT details designs.
When an NFT is either detected or manually imported, i added a call to NFT-API get collections API to fetch more collection data.
References
Changelog
@metamask/assets-controllersdetectNftsfunction.getNftInformationFromApiChecklist