Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NOTIFY-1016): add nameLastUpdatedAt timestamp when setting account name #4589

Merged
merged 12 commits into from
Sep 9, 2024
Merged

feat(NOTIFY-1016): add nameLastUpdatedAt timestamp when setting account name #4589

merged 12 commits into from
Sep 9, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Aug 2, 2024 •
edited
Loading

Explanation

In order to support Account Syncing, we need to update the nameLastUpdatedAt metadata field when an internal account name is changed.

References

NOTIFY-1016

Changelog

@metamask/accounts-controller

  • ADDED: setAccountName action will now update the nameLastUpdatedAt metadata field

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mathieuartu mathieuartu added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Aug 12, 2024
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.0.0-preview-63249efd",
  "@metamask-previews/address-book-controller": "5.0.0-preview-63249efd",
  "@metamask-previews/announcement-controller": "7.0.0-preview-63249efd",
  "@metamask-previews/approval-controller": "7.0.2-preview-63249efd",
  "@metamask-previews/assets-controllers": "37.0.0-preview-63249efd",
  "@metamask-previews/base-controller": "6.0.2-preview-63249efd",
  "@metamask-previews/build-utils": "3.0.0-preview-63249efd",
  "@metamask-previews/chain-controller": "0.1.1-preview-63249efd",
  "@metamask-previews/composable-controller": "7.0.0-preview-63249efd",
  "@metamask-previews/controller-utils": "11.0.2-preview-63249efd",
  "@metamask-previews/ens-controller": "13.0.1-preview-63249efd",
  "@metamask-previews/eth-json-rpc-provider": "4.1.3-preview-63249efd",
  "@metamask-previews/gas-fee-controller": "19.0.1-preview-63249efd",
  "@metamask-previews/json-rpc-engine": "9.0.2-preview-63249efd",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.2-preview-63249efd",
  "@metamask-previews/keyring-controller": "17.1.2-preview-63249efd",
  "@metamask-previews/logging-controller": "5.0.0-preview-63249efd",
  "@metamask-previews/message-manager": "10.0.2-preview-63249efd",
  "@metamask-previews/name-controller": "8.0.0-preview-63249efd",
  "@metamask-previews/network-controller": "20.1.0-preview-63249efd",
  "@metamask-previews/notification-controller": "6.0.0-preview-63249efd",
  "@metamask-previews/notification-services-controller": "0.2.1-preview-63249efd",
  "@metamask-previews/permission-controller": "11.0.0-preview-63249efd",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-63249efd",
  "@metamask-previews/phishing-controller": "10.1.1-preview-63249efd",
  "@metamask-previews/polling-controller": "9.0.1-preview-63249efd",
  "@metamask-previews/preferences-controller": "13.0.1-preview-63249efd",
  "@metamask-previews/profile-sync-controller": "0.2.1-preview-63249efd",
  "@metamask-previews/queued-request-controller": "4.0.0-preview-63249efd",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-63249efd",
  "@metamask-previews/selected-network-controller": "17.0.0-preview-63249efd",
  "@metamask-previews/signature-controller": "18.0.1-preview-63249efd",
  "@metamask-previews/transaction-controller": "35.1.1-preview-63249efd",
  "@metamask-previews/user-operation-controller": "14.0.1-preview-63249efd"
}

@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.0.0-preview-5481b709",
  "@metamask-previews/address-book-controller": "5.0.0-preview-5481b709",
  "@metamask-previews/announcement-controller": "7.0.0-preview-5481b709",
  "@metamask-previews/approval-controller": "7.0.2-preview-5481b709",
  "@metamask-previews/assets-controllers": "37.0.0-preview-5481b709",
  "@metamask-previews/base-controller": "6.0.2-preview-5481b709",
  "@metamask-previews/build-utils": "3.0.0-preview-5481b709",
  "@metamask-previews/chain-controller": "0.1.1-preview-5481b709",
  "@metamask-previews/composable-controller": "7.0.0-preview-5481b709",
  "@metamask-previews/controller-utils": "11.0.2-preview-5481b709",
  "@metamask-previews/ens-controller": "13.0.1-preview-5481b709",
  "@metamask-previews/eth-json-rpc-provider": "4.1.3-preview-5481b709",
  "@metamask-previews/gas-fee-controller": "19.0.1-preview-5481b709",
  "@metamask-previews/json-rpc-engine": "9.0.2-preview-5481b709",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.2-preview-5481b709",
  "@metamask-previews/keyring-controller": "17.1.2-preview-5481b709",
  "@metamask-previews/logging-controller": "5.0.0-preview-5481b709",
  "@metamask-previews/message-manager": "10.0.2-preview-5481b709",
  "@metamask-previews/name-controller": "8.0.0-preview-5481b709",
  "@metamask-previews/network-controller": "20.1.0-preview-5481b709",
  "@metamask-previews/notification-controller": "6.0.0-preview-5481b709",
  "@metamask-previews/notification-services-controller": "0.2.1-preview-5481b709",
  "@metamask-previews/permission-controller": "11.0.0-preview-5481b709",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-5481b709",
  "@metamask-previews/phishing-controller": "10.1.1-preview-5481b709",
  "@metamask-previews/polling-controller": "9.0.1-preview-5481b709",
  "@metamask-previews/preferences-controller": "13.0.1-preview-5481b709",
  "@metamask-previews/profile-sync-controller": "0.2.1-preview-5481b709",
  "@metamask-previews/queued-request-controller": "4.0.0-preview-5481b709",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-5481b709",
  "@metamask-previews/selected-network-controller": "17.0.0-preview-5481b709",
  "@metamask-previews/signature-controller": "18.0.1-preview-5481b709",
  "@metamask-previews/transaction-controller": "35.1.1-preview-5481b709",
  "@metamask-previews/user-operation-controller": "14.0.1-preview-5481b709"
}

@mathieuartu mathieuartu force-pushed the feat/add_timestamp_when_setting_account_name branch from 5481b70 to 55ed7a4 Compare August 19, 2024 15:47
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.0.0-preview-55ed7a46",
  "@metamask-previews/address-book-controller": "5.0.0-preview-55ed7a46",
  "@metamask-previews/announcement-controller": "7.0.0-preview-55ed7a46",
  "@metamask-previews/approval-controller": "7.0.2-preview-55ed7a46",
  "@metamask-previews/assets-controllers": "37.0.0-preview-55ed7a46",
  "@metamask-previews/base-controller": "6.0.2-preview-55ed7a46",
  "@metamask-previews/build-utils": "3.0.0-preview-55ed7a46",
  "@metamask-previews/chain-controller": "0.1.1-preview-55ed7a46",
  "@metamask-previews/composable-controller": "7.0.0-preview-55ed7a46",
  "@metamask-previews/controller-utils": "11.0.2-preview-55ed7a46",
  "@metamask-previews/ens-controller": "13.0.1-preview-55ed7a46",
  "@metamask-previews/eth-json-rpc-provider": "4.1.3-preview-55ed7a46",
  "@metamask-previews/gas-fee-controller": "19.0.1-preview-55ed7a46",
  "@metamask-previews/json-rpc-engine": "9.0.2-preview-55ed7a46",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.2-preview-55ed7a46",
  "@metamask-previews/keyring-controller": "17.1.2-preview-55ed7a46",
  "@metamask-previews/logging-controller": "5.0.0-preview-55ed7a46",
  "@metamask-previews/message-manager": "10.0.2-preview-55ed7a46",
  "@metamask-previews/name-controller": "8.0.0-preview-55ed7a46",
  "@metamask-previews/network-controller": "20.1.0-preview-55ed7a46",
  "@metamask-previews/notification-controller": "6.0.0-preview-55ed7a46",
  "@metamask-previews/notification-services-controller": "0.2.1-preview-55ed7a46",
  "@metamask-previews/permission-controller": "11.0.0-preview-55ed7a46",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-55ed7a46",
  "@metamask-previews/phishing-controller": "10.1.1-preview-55ed7a46",
  "@metamask-previews/polling-controller": "9.0.1-preview-55ed7a46",
  "@metamask-previews/preferences-controller": "13.0.1-preview-55ed7a46",
  "@metamask-previews/profile-sync-controller": "0.2.1-preview-55ed7a46",
  "@metamask-previews/queued-request-controller": "4.0.0-preview-55ed7a46",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-55ed7a46",
  "@metamask-previews/selected-network-controller": "17.0.0-preview-55ed7a46",
  "@metamask-previews/signature-controller": "18.0.1-preview-55ed7a46",
  "@metamask-previews/transaction-controller": "35.1.1-preview-55ed7a46",
  "@metamask-previews/user-operation-controller": "14.0.1-preview-55ed7a46"
}

@mathieuartu mathieuartu force-pushed the feat/add_timestamp_when_setting_account_name branch from 55ed7a4 to c17fb7e Compare August 19, 2024 17:10
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.0.0-preview-c17fb7e4",
  "@metamask-previews/address-book-controller": "5.0.0-preview-c17fb7e4",
  "@metamask-previews/announcement-controller": "7.0.0-preview-c17fb7e4",
  "@metamask-previews/approval-controller": "7.0.2-preview-c17fb7e4",
  "@metamask-previews/assets-controllers": "37.0.0-preview-c17fb7e4",
  "@metamask-previews/base-controller": "6.0.2-preview-c17fb7e4",
  "@metamask-previews/build-utils": "3.0.0-preview-c17fb7e4",
  "@metamask-previews/chain-controller": "0.1.1-preview-c17fb7e4",
  "@metamask-previews/composable-controller": "7.0.0-preview-c17fb7e4",
  "@metamask-previews/controller-utils": "11.0.2-preview-c17fb7e4",
  "@metamask-previews/ens-controller": "13.0.1-preview-c17fb7e4",
  "@metamask-previews/eth-json-rpc-provider": "4.1.3-preview-c17fb7e4",
  "@metamask-previews/gas-fee-controller": "19.0.1-preview-c17fb7e4",
  "@metamask-previews/json-rpc-engine": "9.0.2-preview-c17fb7e4",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.2-preview-c17fb7e4",
  "@metamask-previews/keyring-controller": "17.1.2-preview-c17fb7e4",
  "@metamask-previews/logging-controller": "5.0.0-preview-c17fb7e4",
  "@metamask-previews/message-manager": "10.0.2-preview-c17fb7e4",
  "@metamask-previews/name-controller": "8.0.0-preview-c17fb7e4",
  "@metamask-previews/network-controller": "20.1.0-preview-c17fb7e4",
  "@metamask-previews/notification-controller": "6.0.0-preview-c17fb7e4",
  "@metamask-previews/notification-services-controller": "0.2.1-preview-c17fb7e4",
  "@metamask-previews/permission-controller": "11.0.0-preview-c17fb7e4",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-c17fb7e4",
  "@metamask-previews/phishing-controller": "10.1.1-preview-c17fb7e4",
  "@metamask-previews/polling-controller": "9.0.1-preview-c17fb7e4",
  "@metamask-previews/preferences-controller": "13.0.1-preview-c17fb7e4",
  "@metamask-previews/profile-sync-controller": "0.2.1-preview-c17fb7e4",
  "@metamask-previews/queued-request-controller": "4.0.0-preview-c17fb7e4",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-c17fb7e4",
  "@metamask-previews/selected-network-controller": "17.0.0-preview-c17fb7e4",
  "@metamask-previews/signature-controller": "18.0.1-preview-c17fb7e4",
  "@metamask-previews/transaction-controller": "35.1.1-preview-c17fb7e4",
  "@metamask-previews/user-operation-controller": "14.0.1-preview-c17fb7e4"
}

@mathieuartu mathieuartu force-pushed the feat/add_timestamp_when_setting_account_name branch from c17fb7e to 5dfbc0b Compare August 19, 2024 17:27
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.0.0-preview-5dfbc0bb",
  "@metamask-previews/address-book-controller": "5.0.0-preview-5dfbc0bb",
  "@metamask-previews/announcement-controller": "7.0.0-preview-5dfbc0bb",
  "@metamask-previews/approval-controller": "7.0.2-preview-5dfbc0bb",
  "@metamask-previews/assets-controllers": "37.0.0-preview-5dfbc0bb",
  "@metamask-previews/base-controller": "6.0.2-preview-5dfbc0bb",
  "@metamask-previews/build-utils": "3.0.0-preview-5dfbc0bb",
  "@metamask-previews/chain-controller": "0.1.1-preview-5dfbc0bb",
  "@metamask-previews/composable-controller": "7.0.0-preview-5dfbc0bb",
  "@metamask-previews/controller-utils": "11.0.2-preview-5dfbc0bb",
  "@metamask-previews/ens-controller": "13.0.1-preview-5dfbc0bb",
  "@metamask-previews/eth-json-rpc-provider": "4.1.3-preview-5dfbc0bb",
  "@metamask-previews/gas-fee-controller": "19.0.1-preview-5dfbc0bb",
  "@metamask-previews/json-rpc-engine": "9.0.2-preview-5dfbc0bb",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.2-preview-5dfbc0bb",
  "@metamask-previews/keyring-controller": "17.1.2-preview-5dfbc0bb",
  "@metamask-previews/logging-controller": "5.0.0-preview-5dfbc0bb",
  "@metamask-previews/message-manager": "10.0.2-preview-5dfbc0bb",
  "@metamask-previews/name-controller": "8.0.0-preview-5dfbc0bb",
  "@metamask-previews/network-controller": "20.1.0-preview-5dfbc0bb",
  "@metamask-previews/notification-controller": "6.0.0-preview-5dfbc0bb",
  "@metamask-previews/notification-services-controller": "0.2.1-preview-5dfbc0bb",
  "@metamask-previews/permission-controller": "11.0.0-preview-5dfbc0bb",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-5dfbc0bb",
  "@metamask-previews/phishing-controller": "10.1.1-preview-5dfbc0bb",
  "@metamask-previews/polling-controller": "9.0.1-preview-5dfbc0bb",
  "@metamask-previews/preferences-controller": "13.0.1-preview-5dfbc0bb",
  "@metamask-previews/profile-sync-controller": "0.2.1-preview-5dfbc0bb",
  "@metamask-previews/queued-request-controller": "4.0.0-preview-5dfbc0bb",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-5dfbc0bb",
  "@metamask-previews/selected-network-controller": "17.0.0-preview-5dfbc0bb",
  "@metamask-previews/signature-controller": "18.0.1-preview-5dfbc0bb",
  "@metamask-previews/transaction-controller": "35.1.1-preview-5dfbc0bb",
  "@metamask-previews/user-operation-controller": "14.0.1-preview-5dfbc0bb"
}

@mathieuartu mathieuartu force-pushed the feat/add_timestamp_when_setting_account_name branch from 5dfbc0b to 4c8f928 Compare August 19, 2024 17:34
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "18.0.0-preview-4c8f928a",
  "@metamask-previews/address-book-controller": "5.0.0-preview-4c8f928a",
  "@metamask-previews/announcement-controller": "7.0.0-preview-4c8f928a",
  "@metamask-previews/approval-controller": "7.0.2-preview-4c8f928a",
  "@metamask-previews/assets-controllers": "37.0.0-preview-4c8f928a",
  "@metamask-previews/base-controller": "6.0.2-preview-4c8f928a",
  "@metamask-previews/build-utils": "3.0.0-preview-4c8f928a",
  "@metamask-previews/chain-controller": "0.1.1-preview-4c8f928a",
  "@metamask-previews/composable-controller": "7.0.0-preview-4c8f928a",
  "@metamask-previews/controller-utils": "11.0.2-preview-4c8f928a",
  "@metamask-previews/ens-controller": "13.0.1-preview-4c8f928a",
  "@metamask-previews/eth-json-rpc-provider": "4.1.3-preview-4c8f928a",
  "@metamask-previews/gas-fee-controller": "19.0.1-preview-4c8f928a",
  "@metamask-previews/json-rpc-engine": "9.0.2-preview-4c8f928a",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.2-preview-4c8f928a",
  "@metamask-previews/keyring-controller": "17.1.2-preview-4c8f928a",
  "@metamask-previews/logging-controller": "5.0.0-preview-4c8f928a",
  "@metamask-previews/message-manager": "10.0.2-preview-4c8f928a",
  "@metamask-previews/name-controller": "8.0.0-preview-4c8f928a",
  "@metamask-previews/network-controller": "20.1.0-preview-4c8f928a",
  "@metamask-previews/notification-controller": "6.0.0-preview-4c8f928a",
  "@metamask-previews/notification-services-controller": "0.2.1-preview-4c8f928a",
  "@metamask-previews/permission-controller": "11.0.0-preview-4c8f928a",
  "@metamask-previews/permission-log-controller": "3.0.0-preview-4c8f928a",
  "@metamask-previews/phishing-controller": "10.1.1-preview-4c8f928a",
  "@metamask-previews/polling-controller": "9.0.1-preview-4c8f928a",
  "@metamask-previews/preferences-controller": "13.0.1-preview-4c8f928a",
  "@metamask-previews/profile-sync-controller": "0.2.1-preview-4c8f928a",
  "@metamask-previews/queued-request-controller": "4.0.0-preview-4c8f928a",
  "@metamask-previews/rate-limit-controller": "6.0.0-preview-4c8f928a",
  "@metamask-previews/selected-network-controller": "17.0.0-preview-4c8f928a",
  "@metamask-previews/signature-controller": "18.0.1-preview-4c8f928a",
  "@metamask-previews/transaction-controller": "35.1.1-preview-4c8f928a",
  "@metamask-previews/user-operation-controller": "14.0.1-preview-4c8f928a"
}

@mathieuartu mathieuartu force-pushed the feat/add_timestamp_when_setting_account_name branch from 4c8f928 to 90c0888 Compare August 19, 2024 20:35
@mathieuartu mathieuartu changed the title feat: add nameLastUpdatedAt timestamp when setting account name feat(NOTIFY-1016): add nameLastUpdatedAt timestamp when setting account name Aug 23, 2024
@mathieuartu mathieuartu marked this pull request as ready for review September 9, 2024 07:29
@mathieuartu mathieuartu requested a review from a team as a code owner September 9, 2024 07:29
ccharly
ccharly previously approved these changes Sep 9, 2024
View reviewed changes
@mathieuartu mathieuartu merged commit 0f23b91 into main Sep 9, 2024
116 checks passed
@mathieuartu mathieuartu deleted the feat/add_timestamp_when_setting_account_name branch September 9, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharly ccharly ccharly approved these changes

Assignees
No one assigned
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieuartu @ccharly